Skip to content

Commit 816f908

Browse files
committed
Merge pull request #370 from rmzelle/patch-1
Edit paragraph in 2-contributing.asc (06-github)
2 parents 2721cbe + 5e8203d commit 816f908

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

book/06-github/sections/2-contributing.asc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,8 @@ You can alternatively go to the ``Branches'' page at `https://github.com/<user>/
117117
image::images/blink-02-pr.png[Pull Request button]
118118

119119
(((GitHub, pull requests)))
120-
If we click that green button, we'll see a screen that allows us to create a title and description for the change we would like to request so the project owner has a good reason to consider it. It is generally a good idea to spend some effort making this description as useful as possible so the author knows why this is being suggested and why it would be a valuable change for them to accept.
120+
If we click that green button, we'll see a screen that asks us to give our Pull Request a title and description.
121+
It is almost always worthwhile to put some effort into this, since a good description helps the owner of the original project determine what you were trying to do, whether your proposed changes are correct, and whether accepting the changes would improve the original project.
121122

122123
We also see a list of the commits in our topic branch that are ``ahead'' of the `master` branch (in this case, just the one) and a unified diff of all the changes that will be made should this branch get merged by the project owner.
123124

0 commit comments

Comments
 (0)