misc code cleanups

Author: programmerjake

src/polynomial.rs

@@ -1237,7 +1237,7 @@ impl<T: PolynomialCoefficient> Polynomial<T> {
         T: GCD<Output = T> + PartialOrd,
     {
         if let Some(mut retval) = self.iter().fold(None, |lhs: Option<T>, rhs| match lhs {
-            None => Some(rhs.clone()),
+            None => Some(rhs),
             Some(lhs) => Some(lhs.gcd(&rhs)),
         }) {
             let c = self

src/polynomial/div_rem.rs

@@ -470,7 +470,11 @@ impl<'a, T: PolynomialCoefficient + for<'b> ExactDiv<&'b T, Output = T>> ExactDi
 }
 
 impl<T: PolynomialDivSupported> Polynomial<T> {
-    pub fn checked_powmod<E: Clone + Integer>(&self, exponent: E, modulus: &Self) -> Option<Self> {
+    pub fn checked_powmod<E: Clone + Integer>(
+        &self,
+        mut exponent: E,
+        modulus: &Self,
+    ) -> Option<Self> {
         if exponent < Zero::zero() {
             return None;
         }
@@ -481,7 +485,6 @@ impl<T: PolynomialDivSupported> Polynomial<T> {
         if exponent.is_one() {
             return Some(base);
         }
-        let mut exponent = exponent.clone();
         let mut retval: Option<Self> = None;
         loop {
             if exponent.is_odd() {

src/polynomial/same_degree_factorization.rs

@@ -54,7 +54,7 @@ where
             .to_bigint()
             .expect("can't convert modulus/characteristic to BigInt");
         let polynomial_exponent = (bigint_characteristic.pow(factor_degree) - 1u32) / 2u32;
-        let coefficient_uniform = Uniform::new(V::zero(), characteristic.clone());
+        let coefficient_uniform = Uniform::new(V::zero(), characteristic);
         let mut retval = Vec::new();
         let mut factoring_stack = vec![self.clone()];
         while let Some(mut polynomial) = factoring_stack.pop() {

src/traits.rs

@@ -560,7 +560,6 @@ pub trait ExactDivAssign<Rhs = Self>: ExactDiv<Rhs, Output = Self> {
             panic!("exact division failed");
         }
     }
-    #[must_use]
     fn checked_exact_div_assign(&mut self, rhs: Rhs) -> Result<(), ()>;
 }
 

src/util.rs

@@ -634,7 +634,7 @@ pub trait IsPseudoPrime:
             return false;
         }
         let sqrt = self.sqrt();
-        if sqrt.clone() * sqrt.clone() == *self {
+        if sqrt.clone() * sqrt == *self {
             return false;
         }
         if let Some(value) = self.to_u128() {