Validation

sttts · sttts · commit 25b0d4550188 · 2019-04-14T12:14:49.000+02:00
diff --git a/pkg/apis/restaurant/validation/validation.go b/pkg/apis/restaurant/validation/validation.go
@@ -42,10 +42,10 @@ func ValidatePizzaSpec(s *restaurant.PizzaSpec, fldPath *field.Path) field.Error
 		if len(s.Toppings[i].Name) == 0 {
 			allErrs = append(allErrs, field.Invalid(fldPath.Child("toppings").Index(i).Child("name"), s.Toppings[i].Name, "cannot be empty"))
 		} else {
-			prevNames[s.Toppings[i].Name] = true
 			if prevNames[s.Toppings[i].Name] {
 				allErrs = append(allErrs, field.Invalid(fldPath.Child("toppings").Index(i).Child("name"), s.Toppings[i].Name, "must be unique"))
 			}
+			prevNames[s.Toppings[i].Name] = true
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -42,10 +42,10 @@ func ValidatePizzaSpec(s restaurant.PizzaSpec, fldPath field.Path) field.Error`
`42`	`42`	`if len(s.Toppings[i].Name) == 0 {`
`43`	`43`	`allErrs = append(allErrs, field.Invalid(fldPath.Child("toppings").Index(i).Child("name"), s.Toppings[i].Name, "cannot be empty"))`
`44`	`44`	`} else {`
`45`		`- prevNames[s.Toppings[i].Name] = true`
`46`	`45`	`if prevNames[s.Toppings[i].Name] {`
`47`	`46`	`allErrs = append(allErrs, field.Invalid(fldPath.Child("toppings").Index(i).Child("name"), s.Toppings[i].Name, "must be unique"))`
`48`	`47`	`}`
	`48`	`+ prevNames[s.Toppings[i].Name] = true`
`49`	`49`	`}`
`50`	`50`	`}`
`51`	`51`