unify constants

unify constants into one file used for compilation and installation
for more streamlined configuration changes later on

Author: programminghoch10

compile.sh

@@ -4,6 +4,8 @@ set -e -u
 IFS=$'\n'
 renice -n 19 $$ &>/dev/null
 
+source magiskmodule/constants.sh
+
 GZIP=(gzip --best)
 [ -n "$(command -v pigz)" ] && {
   GZIP=(pigz --best)
@@ -36,10 +38,10 @@ compressFiles() {
 }
 
 echo "Compressing Viper IRS files..."
-compressFiles ViperIRS/"*.irs" magiskmodule/ViperIRS.tar.gz &
+compressFiles ViperIRS/"*.irs" magiskmodule/"$VIPERIRSFILE" &
 
 echo "Compressing Original VDC files..."
-compressFiles OriginalVDCs/"*.vdc" magiskmodule/ViperVDC.tar.gz &
+compressFiles OriginalVDCs/"*.vdc" magiskmodule/"$VIPERVDCFILE" &
 
 wait
 

magiskmodule/constants.sh

@@ -0,0 +1,24 @@
+#!/bin/bash
+
+# minimum required SDK level
+MINAPI=28
+
+# the ViPER4Android user app package
+VIPERFXPACKAGE="com.pittvandewitt.viperfx"
+
+# location of the user folder (commonly referred to as /sdcard)
+SDCARD="/storage/emulated/0"
+
+# location of the ViPER4Android app data folder
+FOLDER="$SDCARD/Android/data/$VIPERFXPACKAGE/files"
+
+# names of the included archives
+VIPERVDCFILE="ViperVDC.tar.gz"
+VIPERIRSFILE="ViperIRS.tar.gz"
+
+# constants for patching system audio config files
+LIBRARY_NAME="v4a_standard_fx"
+EFFECT_NAME="v4a_fx"
+EFFECT_UUID="41d3c987-e6cf-11e3-a88a-11aba5d5c51b"
+LIBRARY_FILE="lib$EFFECT_NAME.so"
+LIBRARY_FILE_PATH="/system/vendor/lib/soundfx/$LIBRARY_FILE"

magiskmodule/customize.sh

@@ -1,12 +1,9 @@
 #!/bin/bash
 
-[ $API -lt 28 ] && abort "Android SDK $API is not supported!"
+[ ! -f "$MODPATH"/constants.sh ] && abort "Missing constants.sh"
+source "$MODPATH"/constants.sh
 
-VIPERFXPACKAGE="com.pittvandewitt.viperfx"
-SDCARD="/storage/emulated/0"
-FOLDER="$SDCARD/Android/data/$VIPERFXPACKAGE/files"
-VIPERVDCFILE="ViperVDC.tar.gz"
-VIPERIRSFILE="ViperIRS.tar.gz"
+[ $API -lt $MINAPI ] && abort "Android SDK $API is not supported!"
 
 IFS=$'\n'
 SEARCH_ROOT="$(magisk --path)/.magisk/mirror"/
@@ -23,13 +20,13 @@ mkdir -p "$FOLDER"
 mkdir -p "$FOLDER"/DDC
 CUSTOM_VDC_FILES=$(find $SDCARD -name '*.vdc' -not -path "$SDCARD/Android/*")
 [ -n "$CUSTOM_VDC_FILES" ] && CUSTOM_VDC_FOUND=true || CUSTOM_VDC_FOUND=false
-[ -f "$MODPATH"/"$VIPERVDCFILE" ] && ORIGINAL_VDC_ARCHIVE_FOUND=true || ORIGINAL_VDC_ARCHIVE_FOUND=false
+[ -f "$MODPATH"/"$VIPERVDCFILE" ] && VDC_ARCHIVE_FOUND=true || VDC_ARCHIVE_FOUND=false
 for file in $(tar -tzf "$MODPATH"/"$VIPERVDCFILE") $CUSTOM_VDC_FILES; do
   file="$FOLDER"/DDC/"$file"
   rmi "$file"
 done
 [ -z "$(ls -A "$FOLDER"/DDC 2>/dev/null)" ] && VDC_FOLDER_EMPTY=true || VDC_FOLDER_EMPTY=false
-if $VDC_FOLDER_EMPTY && ! $CUSTOM_VDC_FOUND && $ORIGINAL_VDC_ARCHIVE_FOUND; then
+if $VDC_FOLDER_EMPTY && ! $CUSTOM_VDC_FOUND && $VDC_ARCHIVE_FOUND; then
   ui_print "- Copying original ViPER4Android VDCs"
   ui_print "   Note that some of these aren't that great"
   ui_print "   Check out https://t.me/vdcservice for better ones"
@@ -39,7 +36,7 @@ else
   ui_print "- Skipping Viper original VDC copy"
   ! $VDC_FOLDER_EMPTY && ui_print "    the folder is not empty"
   $CUSTOM_VDC_FOUND && ui_print "    custom VDCs have been found"
-  ! $ORIGINAL_VDC_ARCHIVE_FOUND && ui_print "    the required data couldn't be located"
+  ! $VDC_ARCHIVE_FOUND && ui_print "    the required data couldn't be located"
 fi
 rmi "$MODPATH"/"$VIPERVDCFILE"
 if $CUSTOM_VDC_FOUND; then
@@ -79,11 +76,6 @@ if $CUSTOM_IRS_FOUND; then
 fi
 
 ui_print "- Patching system audio files"
-LIBRARY_NAME="v4a_standard_fx"
-EFFECT_NAME="v4a_fx"
-EFFECT_UUID="41d3c987-e6cf-11e3-a88a-11aba5d5c51b"
-LIBRARY_FILE="lib$EFFECT_NAME.so"
-LIBRARY_FILE_PATH="/system/vendor/lib/soundfx/$LIBRARY_FILE"
 AUDIO_EFFECTS_FILES="$( \
   find -H \
   $SEARCH_ROOT/system $SEARCH_ROOT/vendor $SEARCH_ROOT/odm \

magiskmodule/service.sh

@@ -1,13 +1,14 @@
 #!/bin/bash
 
+cd "$(dirname "$0")"
+source ./constants.sh
+
 waitUntilBootCompleted() {
   while [ $(getprop sys.boot_completed) -ne 1 ] || [ "$(getprop init.svc.bootanim | tr '[:upper:]' '[:lower:]')" != "stopped" ]; do
     sleep 10
   done
 }
 
-VIPERFXPACKAGE="com.pittvandewitt.viperfx"
-
 (
   waitUntilBootCompleted
   sleep 10

magiskmodule/uninstall.sh

@@ -1,9 +1,11 @@
 
+cd "$(dirname "$0")"
+source ./constants.sh
+
 (
   while [ $(getprop sys.boot_completed) -ne 1 ] || [ "$(getprop init.svc.bootanim | tr '[:upper:]' '[:lower:]')" != "stopped" ]; do
     sleep 1
   done
   sleep 10
-  VIPERFXPACKAGE="com.pittvandewitt.viperfx"
   pm uninstall -k "$VIPERFXPACKAGE"
 ) &