Skip to content

Commit 14c7c08

Browse files
Change how stock equalizers are removed
Instead of disabling AudioFX and reenabling on uninstall we now overlay the AudioFX APK install location to remove the app entirely. This prevents the background running service of AudioFX, which was active even though the package was disabled. Additionally we do the same for SamsungDAP.
1 parent e7ed52a commit 14c7c08

File tree

3 files changed

+22
-12
lines changed

3 files changed

+22
-12
lines changed

magiskmodule/customize.sh

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -81,16 +81,6 @@ for ORIGINAL_FILE in $AUDIO_EFFECTS_FILES; do
8181
esac
8282
done
8383

84-
AUDIOFX_PACKAGE="org.lineageos.audiofx"
85-
if [ -n "$(pm list packages | grep "$AUDIOFX_PACKAGE")" ]; then
86-
ui_print "- Disabling $AUDIOFX_PACKAGE"
87-
if [ -n "$(pm list packages -d | grep "$AUDIOFX_PACKAGE")" ]; then
88-
ui_print" $AUDIOFX_PACKAGE is already disabled"
89-
else
90-
pm disable "$AUDIOFX_PACKAGE"
91-
fi
92-
fi
93-
9484
ui_print "- Installing the ViPER4AndroidFX user app"
9585
APK_INSTALL_FOLDER="/data/local"
9686
(
@@ -111,6 +101,18 @@ cp -f "$MODPATH"/viperfx_preferences.xml "$VIPERFXSHAREDPREFS"/"${VIPERFXPACKAGE
111101
chown -R $VIPERFXPREFSOWNER:$VIPERFXPREFSOWNER "$VIPERFXPREFS"
112102
chown -R $VIPERFXPREFSOWNER "$FOLDER"
113103

104+
IFS=$'\n'
105+
for packagedata in $(sed -e 's/^\s*#.*$//' -e '/^$/d' < "$MODPATH"/stockeqpackages.csv); do
106+
package="$(echo "$packagedata" | cut -d'|' -f1)"
107+
[ -z "$(pm list packages $package)" ] && continue
108+
packagename="$(echo "$packagedata" | cut -d'|' -f2)"
109+
ui_print "- Disabling $packagename"
110+
package_apk="$(pm list packages -f $package | grep -E "package:.*=$package$" | sed "s/package:\(.*\)=$package/\1/")"
111+
package_apk_dir="$(dirname "$package_apk" | sed -e 's|^/||' -e 's|^system/||')"
112+
mkdir -p "$MODPATH"/system/"$package_apk_dir"
113+
touch "$MODPATH"/system/"$package_apk_dir"/.replace
114+
done
115+
114116
ui_print "- Setting Permissions"
115117
set_perm_recursive "$MODPATH" 0 0 0755 0644
116118
set_perm_recursive "$MODPATH"/system/vendor 0 0 0755 0644 u:object_r:vendor_file:s0

magiskmodule/stockeqpackages.csv

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
# This file lists stock audio equalizer packages.
2+
3+
# Every package listed here will be queried in the package manager
4+
# and if it exists
5+
# the entire folder it is contained within will be completely removed
6+
7+
# Format: package|friendlyname
8+
9+
org.lineageos.audiofx|LineageOS AudioFX
10+
org.lineageos.dap|Dolby Atmos

magiskmodule/uninstall.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
sleep 1
55
done
66
sleep 10
7-
AUDIOFXPACKAGE="org.lineageos.audiofx"
8-
[ -n "$(pm list packages -d | grep "$AUDIOFXPACKAGE")" ] && pm enable "$AUDIOFXPACKAGE"
97
VIPERFXPACKAGE="com.pittvandewitt.viperfx"
108
pm uninstall -k "$VIPERFXPACKAGE"
119
) &

0 commit comments

Comments
 (0)