Merge pull request #1133 from progressonderwijs/tc/optionally_clear_pools

Tc/optionally clear pools

Author: tjibbechris

src/ProgressOnderwijsUtils/Data/SqlServerUtils.cs

@@ -5,7 +5,7 @@ public static class SqlServerUtils
     /// <summary>
     /// If the catalog in question does not exist, this method does nothing.
     /// </summary>
-    public static void KillOtherUserProcessesOnDb(SqlConnection sqlContext, string catalog)
+    public static void KillOtherUserProcessesOnDb(SqlConnection sqlContext, string catalog, bool clearAllPools)
     {
         try {
             SQL(
@@ -26,6 +26,9 @@ and s.status in ('running', 'sleeping')
         } catch (Exception e) when (IsSpidAlreadyDeadException(e)) {
             //the spid may already be dead by the time we get around to killing it, which throws an error.  We ignore that error.
         }
+        if (clearAllPools) {
+            SqlConnection.ClearAllPools();
+        }
     }
 
     static bool IsSpidAlreadyDeadException(Exception exception)

src/ProgressOnderwijsUtils/ProgressOnderwijsUtils.csproj

@@ -1,8 +1,8 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
   <Import Project="..\NugetPackagesCommon.props" />
   <PropertyGroup Label="Configuration">
-    <Version>105.2.6</Version>
-    <PackageReleaseNotes>Bump versions.</PackageReleaseNotes>
+    <Version>105.3.0</Version>
+    <PackageReleaseNotes>Allow for clearing of connection pool after killing spids.</PackageReleaseNotes>
     <Title>ProgressOnderwijsUtils</Title>
     <Description>Collection of utilities developed by ProgressOnderwijs</Description>
     <PackageTags>ProgressOnderwijs</PackageTags>

test/ProgressOnderwijsUtils.Tests/Data/SqlServerUtilsTest.cs

@@ -4,5 +4,5 @@ public sealed class SqlServerUtilsTest : TransactedLocalConnection
 {
     [Fact]
     public void KillOtherUserProcessesOnDb_works_on_non_existing_catalog()
-        => SqlServerUtils.KillOtherUserProcessesOnDb(Connection, nameof(KillOtherUserProcessesOnDb_works_on_non_existing_catalog));
+        => SqlServerUtils.KillOtherUserProcessesOnDb(Connection, nameof(KillOtherUserProcessesOnDb_works_on_non_existing_catalog), true);
 }