Merge pull request #1144 from progressonderwijs/fons/fix_warns

Bumped dependencies and fixed some warnings

Author: fdij

src/ProgressOnderwijsUtils.Analyzers/MustUseExpressionResultAnalyzer.cs

@@ -21,7 +21,7 @@ public sealed class MustUseExpressionResultAnalyzer : DiagnosticAnalyzer
     );
 
     public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
-        => ImmutableArray.Create(Rule);
+        => [Rule];
 
     public override void Initialize(AnalysisContext context)
     {

src/ProgressOnderwijsUtils.Analyzers/RedundantAssertNotNullAnalyzer.cs

@@ -1,4 +1,3 @@
-using System.Collections.Generic;
 using System.Collections.Immutable;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;

src/ProgressOnderwijsUtils.AspNetCore/ModelStateFilter.cs

@@ -1,4 +1,3 @@
-using System;
 using Microsoft.AspNetCore.Mvc.Filters;
 using Microsoft.AspNetCore.Mvc;
 

src/ProgressOnderwijsUtils.SeleniumWebDriverPool/WebDriverPool.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Concurrent;
-using System.Collections.Generic;
 using OpenQA.Selenium;
 using OpenQA.Selenium.Chrome;
 using OpenQA.Selenium.Remote;

src/ProgressOnderwijsUtils/Collections/ProjectingEqualityComparer.cs

@@ -15,7 +15,7 @@ public sealed class ProjectingEqualityComparer<T>
     ProjectingEqualityComparer(EqualsComparer[] equality, HashComputation[] hash)
         => (Equality, Hash) = (equality, hash);
 
-    public ProjectingEqualityComparer() : this(Array.Empty<EqualsComparer>(), Array.Empty<HashComputation>()) { }
+    public ProjectingEqualityComparer() : this([], []) { }
 
     public ProjectingEqualityComparer<T> AddKeyColumn<TPart>(Func<T, TPart> part, IEqualityComparer<TPart> partComparer)
         => AddKey_WithoutColumn(([DisallowNull] a, [DisallowNull] b) => partComparer.Equals(part(a), part(b)), ([DisallowNull] o) => part(o) is { } nonNull ? partComparer.GetHashCode(nonNull) : 0);
@@ -72,10 +72,10 @@ int CombinedHash([DisallowNull] T obj)
         return new Equatable(CombinedEquality, CombinedHash);
     }
 
-    sealed record Equatable(EqualsComparer EqualsComparer, HashComputation Hash) : IEqualityComparer<T>
+    sealed record Equatable(EqualsComparer Comparer, HashComputation Hash) : IEqualityComparer<T>
     {
         public bool Equals(T? x, T? y)
-            => x is null ? y is null : y is not null && EqualsComparer(x, y);
+            => x is null ? y is null : y is not null && Comparer(x, y);
 
         public int GetHashCode(T obj)
             => obj is null ? 0 : Hash(obj);

src/ProgressOnderwijsUtils/Data/ParameterizedSql.cs

@@ -96,7 +96,6 @@ static bool ValidSubsequentIdentifierChar(char c) //https://learn.microsoft.com/
     /// </summary>
     public static ParameterizedSql UnescapedSqlIdentifier(string rawSqlString)
     {
-        ArgumentNullException.ThrowIfNull(nameof(rawSqlString));
         AssertIsIdentifier(rawSqlString, 0);
         return new StringSqlFragment(rawSqlString).BuildableToQuery();
     }

src/ProgressOnderwijsUtils/Html/HtmlDirectory.cs

@@ -1,7 +1,3 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-
 namespace ProgressOnderwijsUtils.Html;
 
 sealed class HtmlDirectory

src/ProgressOnderwijsUtils/Html/HtmlToStringExtensions.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Buffers;
 using System.IO.Pipelines;
 

src/ProgressOnderwijsUtils/ProgressOnderwijsUtils.csproj

@@ -1,8 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <Import Project="..\NugetPackagesCommon.props" />
   <PropertyGroup Label="Configuration">
-    <Version>105.5.0</Version>
-    <PackageReleaseNotes>QualifiedNameSql property added to SequenceSqlDefinition</PackageReleaseNotes>
+    <Version>105.5.1</Version>
+    <PackageReleaseNotes>Bumped dependencies and fixed some warnings</PackageReleaseNotes>
     <Title>ProgressOnderwijsUtils</Title>
     <Description>Collection of utilities developed by ProgressOnderwijs</Description>
     <PackageTags>ProgressOnderwijs</PackageTags>

test/ProgressOnderwijsUtils.Tests/Collections/SortedSet_MergeSetsTest.cs

@@ -1,4 +1,3 @@
-using System.Linq;
 using IntSet = ProgressOnderwijsUtils.Collections.SortedSet<int, ProgressOnderwijsUtils.Tests.Collections.IntOrdering>;
 
 namespace ProgressOnderwijsUtils.Tests.Collections;