Merge pull request #1204 from progressonderwijs/robin/optional-instead-of-throw

Fix crash when disposing SqlConnectionContext (calling SiteBase.Name for logging/diagnostic purposes)

Author: Bazeloth

src/ProgressOnderwijsUtils/Data/SiteBase.cs

@@ -16,9 +16,5 @@ public virtual IContainer? Container
     public virtual bool DesignMode
         => throw new NotSupportedException();
 
-    public virtual string? Name
-    {
-        get => throw new NotSupportedException();
-        set => throw new NotSupportedException();
-    }
+    public string? Name { get; set; }
 }

src/ProgressOnderwijsUtils/Data/SqlCommandCreationContext.cs

@@ -10,14 +10,8 @@ public interface IHasDefaultCommandTimeout
     CommandTimeoutDefaults TimeoutDefaults { get; }
 }
 
-public sealed class SqlConnectionContext : SiteBase, IAttachedToTracer, IHasDefaultCommandTimeout
+public sealed class SqlConnectionContext(ISqlCommandTracer tracer, CommandTimeoutDefaults timeoutDefaults) : SiteBase, IAttachedToTracer, IHasDefaultCommandTimeout
 {
-    public SqlConnectionContext(ISqlCommandTracer tracer, CommandTimeoutDefaults timeoutDefaults)
-    {
-        Tracer = tracer;
-        TimeoutDefaults = timeoutDefaults;
-    }
-
-    public ISqlCommandTracer Tracer { get; }
-    public CommandTimeoutDefaults TimeoutDefaults { get; set; }
+    public ISqlCommandTracer Tracer { get; } = tracer;
+    public CommandTimeoutDefaults TimeoutDefaults { get; set; } = timeoutDefaults;
 }

src/ProgressOnderwijsUtils/ProgressOnderwijsUtils.csproj

@@ -1,8 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <Import Project="..\NugetPackagesCommon.props" />
   <PropertyGroup Label="Configuration">
-    <Version>110.2.0</Version>
-    <PackageReleaseNotes>Give the possibility to serialize rowversion columns to number properties in the JSON reader.</PackageReleaseNotes>
+    <Version>110.3.0</Version>
+    <PackageReleaseNotes>Do not throw on accessing the Name of SqlConnectionContext to prevent errors on disposing.</PackageReleaseNotes>
     <Title>ProgressOnderwijsUtils</Title>
     <Description>Collection of utilities developed by ProgressOnderwijs</Description>
     <PackageTags>ProgressOnderwijs</PackageTags>