Skip to content

Commit 0c8e455

Browse files
committed
RSS: When deleting a named feed, preserve anonymous feed of the same URL.
1 parent cbd2b31 commit 0c8e455

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

plugins/RSS/plugin.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,9 @@ def assert_feed_does_not_exist(self, name, url=None):
287287

288288
def register_feed(self, name, url, initial,
289289
plugin_is_loading, announced=None):
290-
self.feed_names[name] = url
290+
if name != url:
291+
# If name == url, then it's an anonymous feed
292+
self.feed_names[name] = url
291293
self.feeds[url] = Feed(name, url, initial,
292294
plugin_is_loading, announced)
293295

plugins/RSS/test.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ def testRemoveAliasedFeed(self, mock):
111111
self.assertNotError('rss announce remove http://xkcd.com/rss.xml')
112112
self.assertNotError('rss remove xkcd')
113113
self.assertEqual(self.irc.getCallback('RSS').feed_names, {})
114+
self.assertTrue(self.irc.getCallback('RSS').get_feed('http://xkcd.com/rss.xml'))
114115

115116
@mock_urllib
116117
def testInitialAnnounceNewest(self, mock):

0 commit comments

Comments
 (0)