enable a few more linters

Author: dgrove-oss

.golangci.yml

@@ -18,8 +18,10 @@ linters:
   enable:
   - copyloopvar
   - dupl
+  - dupword
   - errcheck
   - gci
+  - ginkgolinter
   - goconst
   - gocyclo
   - gofmt

internal/controller/appwrapper/node_health_monitor_test.go

@@ -76,7 +76,7 @@ var _ = Describe("NodeMonitor Controller", func() {
 		Expect(err).NotTo(HaveOccurred())
 
 		By("Healthy cluster has no unhealthy nodes")
-		Expect(len(noExecuteNodes)).Should(Equal(0))
+		Expect(noExecuteNodes).Should(BeEmpty())
 
 		By("A node labeled EVICT is detected as unhealthy")
 		node := getNode(node1Name.Name)
@@ -86,7 +86,7 @@ var _ = Describe("NodeMonitor Controller", func() {
 		Expect(err).NotTo(HaveOccurred())
 		_, err = nodeMonitor.Reconcile(ctx, reconcile.Request{NamespacedName: node2Name})
 		Expect(err).NotTo(HaveOccurred())
-		Expect(len(noExecuteNodes)).Should(Equal(1))
+		Expect(noExecuteNodes).Should(HaveLen(1))
 		Expect(noExecuteNodes).Should(HaveKey(node1Name.Name))
 		Expect(noExecuteNodes[node1Name.Name]).Should(HaveKey("nvidia.com/gpu"))
 
@@ -95,7 +95,7 @@ var _ = Describe("NodeMonitor Controller", func() {
 		Expect(err).NotTo(HaveOccurred())
 		_, err = nodeMonitor.Reconcile(ctx, reconcile.Request{NamespacedName: node2Name})
 		Expect(err).NotTo(HaveOccurred())
-		Expect(len(noExecuteNodes)).Should(Equal(1))
+		Expect(noExecuteNodes).Should(HaveLen(1))
 		Expect(noExecuteNodes).Should(HaveKey(node1Name.Name))
 		Expect(noExecuteNodes[node1Name.Name]).Should(HaveKey("nvidia.com/gpu"))
 
@@ -104,7 +104,7 @@ var _ = Describe("NodeMonitor Controller", func() {
 		Expect(k8sClient.Update(ctx, node)).Should(Succeed())
 		_, err = nodeMonitor.Reconcile(ctx, reconcile.Request{NamespacedName: node1Name})
 		Expect(err).NotTo(HaveOccurred())
-		Expect(len(noExecuteNodes)).Should(Equal(0))
+		Expect(noExecuteNodes).Should(BeEmpty())
 
 		deleteNode(node1Name.Name)
 		deleteNode(node2Name.Name)