fix: usesGpus needs to wait for env.json file to exist

also picks up some fixes from the store for torchx env file population

Author: starpit

package-lock.json

@@ -26,7 +26,7 @@ export type Tail = {
   quit: TailFile["quit"]
 }
 
-function waitTillExists(filepath: string) {
+export function waitTillExists(filepath: string) {
   const watcher = chokidar.watch(filepath)
   return new Promise<void>((resolve, reject) => {
     watcher.on("add", () => resolve())

plugins/plugin-codeflare-dashboard/src/controller/dashboard/tailf.ts

@@ -35,10 +35,14 @@ function toRecord(nva: NameValue[]): Record<string, unknown> {
   }, {} as Record<string, unknown>)
 }
 
+async function getJobEnvFilepath(profile: string, jobId: string): Promise<string> {
+  return join(await import("./path.js").then((_) => _.pathFor(profile, jobId)), "env.json")
+}
+
 export async function getJobEnv(profile: string, jobId: string): Promise<Record<string, unknown>> {
-  const filepath = await import("./path.js").then((_) => _.pathFor(profile, jobId))
+  const filepath = await getJobEnvFilepath(profile, jobId)
   const nameValueArray = JSON.parse(
-    await import("fs/promises").then((_) => _.readFile(join(filepath, "env.json"))).then((_) => _.toString())
+    await import("fs/promises").then((_) => _.readFile(filepath)).then((_) => _.toString())
   )
   if (!isNameValueArray(nameValueArray)) {
     throw new Error("Malformatted env.json file")
@@ -48,6 +52,9 @@ export async function getJobEnv(profile: string, jobId: string): Promise<Record<
 }
 
 export async function numGpus(profile: string, jobId: string): Promise<number> {
+  const filepath = await getJobEnvFilepath(profile, jobId)
+  await import("./dashboard/tailf.js").then((_) => _.waitTillExists(filepath))
+
   try {
     const env = await getJobEnv(profile, jobId)
 

plugins/plugin-codeflare-dashboard/src/controller/env.ts

@@ -30,7 +30,7 @@
     "@types/split2": "^3.2.1"
   },
   "dependencies": {
-    "@guidebooks/store": "^7.5.13",
+    "@guidebooks/store": "^7.5.15",
     "@logdna/tail-file": "^3.0.1",
     "@patternfly/react-charts": "^6.94.18",
     "@patternfly/react-core": "^4.276.6",