fix: more fixes for profile switch is not sticky

Author: starpit

package-lock.json

@@ -117,7 +117,7 @@ export default class ProfileExplorer extends React.PureComponent<Props, State> {
   private readonly onSelect = async (evt: React.MouseEvent<HTMLElement>) => {
     const selectedProfile = evt.currentTarget.getAttribute("data-profile")
     evt.currentTarget.scrollIntoView(true)
-    if (selectedProfile) {
+    if (selectedProfile && selectedProfile !== this.state.selectedProfile) {
       if (await Profiles.bumpLastUsedTime(selectedProfile)) {
         emitSelectProfile(selectedProfile)
         this.setState({ selectedProfile })

plugins/plugin-codeflare/src/components/ProfileExplorer.tsx

@@ -56,6 +56,10 @@ export default class RestartableTerminal extends React.PureComponent<Props, Stat
   private mounted = false
 
   private async initPty() {
+    if (!this.mounted) {
+      return
+    }
+
     try {
       // we need this to wire the pty output through to the Terminal
       // component, which expects something stream-like

plugins/plugin-codeflare/src/components/RestartableTerminal.tsx

@@ -17,7 +17,7 @@
 import React from "react"
 import { Loading } from "@kui-shell/plugin-client-common"
 
-import Terminal, { Props } from "./RestartableTerminal"
+import RestartableTerminal, { Props } from "./RestartableTerminal"
 import { onSelectProfile, offSelectProfile } from "./ProfileExplorer"
 
 type State = {
@@ -55,7 +55,7 @@ export default class SelectedProfileTerminal extends React.PureComponent<Props,
     if (!this.state || !this.state.cmdline) {
       return <Loading />
     } else {
-      return <Terminal key={this.state.cmdline} {...this.props} cmdline={this.state.cmdline} />
+      return <RestartableTerminal key={this.state.cmdline} {...this.props} cmdline={this.state.cmdline} />
     }
   }
 }

plugins/plugin-codeflare/src/components/SelectedProfileTerminal.tsx

@@ -23,6 +23,6 @@
     "access": "public"
   },
   "dependencies": {
-    "madwizard": "^0.18.2"
+    "madwizard": "^0.18.3"
   }
 }