fix: cheat and make default window width slightly wider to fix current guidebook content

This PR also cleans up the many random hard-coded uses of the desired initial window width and height.

Author: starpit

plugins/plugin-client-default/config.d/style.json

@@ -1,6 +1,6 @@
 {
   "bodyCss": "codeflare",
-  "width": 1200,
+  "width": 1204,
   "height": 800,
   "frame": false,
   "titleBarStyle": "hiddenInset",

plugins/plugin-codeflare/src/controller/index.ts

@@ -17,6 +17,8 @@
 import { KResponse, Registrar } from "@kui-shell/core"
 import { MadWizardOptions } from "@kui-shell/plugin-madwizard"
 
+import { width, height } from "@kui-shell/client/config.d/style.json"
+
 import s3 from "./s3"
 import tailf from "./tailf"
 import browse from "./browse"
@@ -46,8 +48,8 @@ export default function registerCodeflareCommands(registrar: Registrar) {
   registrar.listen("/codeflare/version", () => import("@kui-shell/client/package.json").then((_) => _.version))
   registrar.listen("/codeflare/gui/guide", (args) => import("./guide").then((_) => _.default(args)), {
     needsUI: true,
-    width: 1280,
-    height: 800,
+    width,
+    height,
   })
 
   registrar.listen("/codeflare/rename/profile", (args) => import("./profile/rename").then((_) => _.default(args)))
@@ -64,8 +66,8 @@ export default function registerCodeflareCommands(registrar: Registrar) {
   registrar.listen("/codeflare/explore", (args) => import("./hello").then((_) => _.default(args)), {
     needsUI: true,
     outputOnly: true,
-    width: 1200,
-    height: 800,
+    width,
+    height,
   })
 
   /**

plugins/plugin-codeflare/src/controller/profile/actions.ts

@@ -14,6 +14,8 @@
  * limitations under the License.
  */
 
+import { width, height } from "@kui-shell/client/config.d/style.json"
+
 export async function openWindow(title: string, initialTabTitle: string, argv: (string | undefined)[]) {
   const { ipcRenderer } = await import("electron")
 
@@ -23,8 +25,8 @@ export async function openWindow(title: string, initialTabTitle: string, argv: (
       operation: "new-window",
       title,
       initialTabTitle,
-      width: 1200,
-      height: 800,
+      width,
+      height,
       argv,
     })
   )

plugins/plugin-codeflare/src/tray/menus/index.ts

@@ -16,8 +16,9 @@
 
 import { CreateWindowFunction } from "@kui-shell/core"
 
-import { productName } from "@kui-shell/client/config.d/name.json"
 import { bugs, version } from "@kui-shell/client/package.json"
+import { productName } from "@kui-shell/client/config.d/name.json"
+import { width, height } from "@kui-shell/client/config.d/style.json"
 
 import profilesMenu from "./profiles"
 import UpdateFunction from "../update"
@@ -37,7 +38,7 @@ export default async function buildContextMenu(
     {
       label: `Explore CodeFlare`,
       icon: gettingStartedIcon,
-      click: () => createWindow([], { width: 1200, height: 800 }),
+      click: () => createWindow([], { width, height }),
     },
     { label: `Report a Bug`, icon: bugIcon, click: () => import("open").then((_) => _.default(bugs.url)) },
     { label: `Quit ${productName}`, icon: powerOffIcon, role: "quit" },