Disable MCAD by default

Signed-off-by: Anish Asthana <[email protected]>

Author: anishasthana

main.go

@@ -127,7 +127,8 @@ func main() {
 			},
 			LeaderElection: &configv1alpha1.LeaderElectionConfiguration{},
 		},
-		MCAD: &mcadconfig.MCADConfiguration{},
+		MCADEnabled: pointer.Bool(false),
+		MCAD:        &mcadconfig.MCADConfiguration{},
 		InstaScale: &config.InstaScaleConfiguration{
 			Enabled: pointer.Bool(false),
 			InstaScaleConfiguration: instascaleconfig.InstaScaleConfiguration{
@@ -167,12 +168,14 @@ func main() {
 	})
 	exitOnError(err, "unable to start manager")
 
-	mcadQueueController := mcad.NewJobController(mgr.GetConfig(), cfg.MCAD, &mcadconfig.MCADConfigurationExtended{})
-	if mcadQueueController == nil {
-		// FIXME: update NewJobController so it follows Go idiomatic error handling and return an error instead of a nil object
-		os.Exit(1)
+	if pointer.BoolDeref(cfg.MCADEnabled, false) {
+		mcadQueueController := mcad.NewJobController(mgr.GetConfig(), cfg.MCAD, &mcadconfig.MCADConfigurationExtended{})
+		if mcadQueueController == nil {
+			// FIXME: update NewJobController so it follows Go idiomatic error handling and return an error instead of a nil object
+			os.Exit(1)
+		}
+		mcadQueueController.Run(ctx.Done())
 	}
-	mcadQueueController.Run(ctx.Done())
 
 	if pointer.BoolDeref(cfg.InstaScale.Enabled, false) {
 		instaScaleController := &instascale.AppWrapperReconciler{

pkg/config/config.go

@@ -32,7 +32,9 @@ type CodeFlareOperatorConfiguration struct {
 	ControllerManager `json:",inline"`
 
 	// The MCAD controller configuration
-	MCAD *mcad.MCADConfiguration `json:"mcad,omitempty"`
+	// MCADEnabled defaults to false
+	MCADEnabled *bool                   `json:"mcadEnabled,omitempty"`
+	MCAD        *mcad.MCADConfiguration `json:"mcad,omitempty"`
 
 	// The InstaScale controller configuration
 	InstaScale *InstaScaleConfiguration `json:"instascale,omitempty"`

test/e2e/setup.sh

@@ -56,3 +56,13 @@ roleRef:
   kind: ClusterRole
   name: mcad-controller-rayclusters
 EOF
+
+cat <<EOF | kubectl apply -f -
+kind: ConfigMap
+apiVersion: v1
+metadata:
+  name: codeflare-operator-config
+data:
+  config.yaml: |
+    mcadEnabled: true
+EOF