Skip to content

Commit 1bbe0ef

Browse files
authored
Revert "docs: add new documentation and fix existing docs"
This reverts commit 9288016.
1 parent 9288016 commit 1bbe0ef

File tree

11 files changed

+28
-176
lines changed

11 files changed

+28
-176
lines changed

README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ For guided demos and basics walkthroughs, check out the following links:
1111
- these demos can be copied into your current working directory when using the `codeflare-sdk` by using the `codeflare_sdk.copy_demo_nbs()` function
1212
- Additionally, we have a [video walkthrough](https://www.youtube.com/watch?v=U76iIfd9EmE) of these basic demos from June, 2023
1313

14-
Full documentation can be found [here](https://project-codeflare.github.io/codeflare-sdk/index.html)
14+
Full documentation can be found [here](https://project-codeflare.github.io/codeflare-sdk/detailed-documentation)
1515

1616
## Installation
1717

@@ -32,10 +32,11 @@ It is possible to use the Release Github workflow to do the release. This is gen
3232
The following instructions apply when doing release manually. This may be required in instances where the automation is failing.
3333

3434
- Check and update the version in "pyproject.toml" file.
35+
- Generate new documentation.
36+
`pdoc --html -o docs src/codeflare_sdk && pushd docs && rm -rf cluster job utils && mv codeflare_sdk/* . && rm -rf codeflare_sdk && popd && find docs -type f -name "*.html" -exec bash -c "echo '' >> {}" \;` (it is possible to install **pdoc** using the following command `poetry install --with docs`)
3537
- Commit all the changes to the repository.
3638
- Create Github release (<https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository#creating-a-release>).
3739
- Build the Python package. `poetry build`
3840
- If not present already, add the API token to Poetry.
3941
`poetry config pypi-token.pypi API_TOKEN`
4042
- Publish the Python package. `poetry publish`
41-
- Trigger the [Publish Documentation](https://github.com/project-codeflare/codeflare-sdk/actions/workflows/publish-documentation.yaml) workflow

docs/sphinx/index.rst

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,14 @@ The CodeFlare SDK is an intuitive, easy-to-use python interface for batch resour
1616
modules
1717

1818
.. toctree::
19-
:maxdepth: 1
19+
:maxdepth: 2
2020
:caption: User Documentation:
2121

2222
user-docs/authentication
2323
user-docs/cluster-configuration
24-
user-docs/ray-cluster-interaction
2524
user-docs/e2e
2625
user-docs/s3-compatible-storage
2726
user-docs/setup-kueue
28-
user-docs/ui-widgets
2927

3028
Quick Links
3129
===========

docs/sphinx/user-docs/authentication.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ a login command like ``oc login --token=<token> --server=<server>``
3939
their kubernetes config file should have updated. If the user has not
4040
specifically authenticated through the SDK by other means such as
4141
``TokenAuthentication`` then the SDK will try to use their default
42-
Kubernetes config file located at ``"$HOME/.kube/config"``.
42+
Kubernetes config file located at ``"/HOME/.kube/config"``.
4343

4444
Method 3 Specifying a Kubernetes Config File
4545
--------------------------------------------
@@ -62,5 +62,5 @@ Method 4 In-Cluster Authentication
6262
----------------------------------
6363

6464
If a user does not authenticate by any of the means detailed above and
65-
does not have a config file at ``"$HOME/.kube/config"`` the SDK will try
65+
does not have a config file at ``"/HOME/.kube/config"`` the SDK will try
6666
to authenticate with the in-cluster configuration file.

docs/sphinx/user-docs/cluster-configuration.rst

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,13 @@ requirements for creating the Ray Cluster.
2929
labels={"exampleLabel": "example", "secondLabel": "example"},
3030
))
3131
32-
.. note::
33-
`quay.io/modh/ray:2.35.0-py39-cu121` is the default image used by
34-
the CodeFlare SDK for creating a RayCluster resource. If you have your
35-
own Ray image which suits your purposes, specify it in image field to
36-
override the default image. If you are using ROCm compatible GPUs you
37-
can use `quay.io/modh/ray:2.35.0-py39-rocm61`. You can also find
38-
documentation on building a custom image
39-
`here <https://github.com/opendatahub-io/distributed-workloads/tree/main/images/runtime/examples>`__.
32+
Note: ‘quay.io/modh/ray:2.35.0-py39-cu121’ is the default image used by
33+
the CodeFlare SDK for creating a RayCluster resource. If you have your
34+
own Ray image which suits your purposes, specify it in image field to
35+
override the default image. If you are using ROCm compatible GPUs you
36+
can use ‘quay.io/modh/ray:2.35.0-py39-rocm61’. You can also find
37+
documentation on building a custom image
38+
`here <https://github.com/opendatahub-io/distributed-workloads/tree/main/images/runtime/examples>`__.
4039

4140
The ``labels={"exampleLabel": "example"}`` parameter can be used to
4241
apply additional labels to the RayCluster resource.
@@ -47,8 +46,7 @@ After creating their ``cluster``, a user can call ``cluster.up()`` and
4746
Deprecating Parameters
4847
----------------------
4948

50-
The following parameters of the ``ClusterConfiguration`` are being
51-
deprecated.
49+
The following parameters of the ``ClusterConfiguration`` are being deprecated.
5250

5351
.. list-table::
5452
:header-rows: 1

docs/sphinx/user-docs/e2e.rst

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ On KinD clusters
1111

1212
Pre-requisite for KinD clusters: please add in your local ``/etc/hosts``
1313
file ``127.0.0.1 kind``. This will map your localhost IP address to the
14-
KinD cluster's hostname. This is already performed on `GitHub
14+
KinD clusters hostname. This is already performed on `GitHub
1515
Actions <https://github.com/project-codeflare/codeflare-common/blob/1edd775e2d4088a5a0bfddafb06ff3a773231c08/github-actions/kind/action.yml#L70-L72>`__
1616

1717
If the system you run on contains NVidia GPU then you can enable the GPU
@@ -91,7 +91,7 @@ instructions <https://www.substratus.ai/blog/kind-with-gpus>`__.
9191
poetry install --with test,docs
9292
poetry run pytest -v -s ./tests/e2e/mnist_raycluster_sdk_kind_test.py
9393

94-
- If the cluster doesn't have NVidia GPU support then we need to
94+
- If the cluster doesnt have NVidia GPU support then we need to
9595
disable NVidia GPU tests by providing proper marker:
9696

9797
::
@@ -124,8 +124,8 @@ If the system you run on contains NVidia GPU then you can enable the GPU
124124
support on OpenShift, this will allow you to run also GPU tests. To
125125
enable GPU on OpenShift follow `these
126126
instructions <https://docs.nvidia.com/datacenter/cloud-native/openshift/latest/introduction.html>`__.
127-
Currently the SDK doesn't support tolerations, so e2e tests can't be
128-
executed on nodes with taint (i.e. GPU taint).
127+
Currently the SDK doesnt support tolerations, so e2e tests cant be
128+
executed on nodes with taint (i.e. GPU taint).
129129

130130
- Test Phase:
131131

@@ -203,9 +203,8 @@ On OpenShift Disconnected clusters
203203
AWS_STORAGE_BUCKET=<storage-bucket-name>
204204
AWS_STORAGE_BUCKET_MNIST_DIR=<storage-bucket-MNIST-datasets-directory>
205205

206-
.. note::
207-
When using the Python Minio client to connect to a minio
208-
storage bucket, the ``AWS_DEFAULT_ENDPOINT`` environment
209-
variable by default expects secure endpoint where user can use
210-
endpoint url with https/http prefix for autodetection of
211-
secure/insecure endpoint.
206+
Note : When using the Python Minio client to connect to a minio
207+
storage bucket, the ``AWS_DEFAULT_ENDPOINT`` environment
208+
variable by default expects secure endpoint where user can use
209+
endpoint url with https/http prefix for autodetection of
210+
secure/insecure endpoint.
-21.9 KB
Binary file not shown.
-28.1 KB
Binary file not shown.

docs/sphinx/user-docs/ray-cluster-interaction.rst

Lines changed: 0 additions & 90 deletions
This file was deleted.

docs/sphinx/user-docs/s3-compatible-storage.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,5 +82,5 @@ Lastly the new ``run_config`` must be added to the Trainer:
8282
To find more information on creating a Minio Bucket compatible with
8383
RHOAI you can refer to this
8484
`documentation <https://ai-on-openshift.io/tools-and-applications/minio/minio/>`__.
85-
Note: You must have ``s3fs`` and ``pyarrow`` installed in your
85+
Note: You must have ``sf3s`` and ``pyarrow`` installed in your
8686
environment for this method.

docs/sphinx/user-docs/setup-kueue.rst

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,10 @@ Kueue resources, namely Cluster Queue, Resource Flavor, and Local Queue.
1111
1. Resource Flavor:
1212
-------------------
1313

14-
Resource Flavors allow the cluster admin to reflect differing resource capabilities
15-
of nodes within a clusters, such as CPU, memory, GPU, etc. These can then be assigned
16-
to workloads to ensure they are executed on nodes with appropriate resources.
14+
Resource Flavors allow the cluster admin to define different types of
15+
resources with specific characteristics, such as CPU, memory, GPU, etc.
16+
These can then be assigned to workloads to ensure they are executed on
17+
appropriate resources.
1718

1819
The YAML configuration provided below creates an empty Resource Flavor
1920
named default-flavor. It serves as a starting point and does not specify

0 commit comments

Comments
 (0)