updated test

Signed-off-by: Pat O'Connor <[email protected]>

Author: chipspeak

src/codeflare_sdk/ray/rayjobs/test_rayjob.py

@@ -89,8 +89,14 @@ def test_rayjob_submit_failure(mocker):
         rayjob.submit()
 
 
-def test_rayjob_init_validation_both_provided():
+def test_rayjob_init_validation_both_provided(mocker):
     """Test that providing both cluster_name and cluster_config raises error."""
+    # Mock kubernetes config loading
+    mocker.patch("kubernetes.config.load_kube_config")
+    
+    # Mock the RayjobApi class entirely
+    mocker.patch("codeflare_sdk.ray.rayjobs.rayjob.RayjobApi")
+    
     cluster_config = ClusterConfiguration(name="test-cluster", namespace="test")
 
     with pytest.raises(
@@ -104,16 +110,28 @@ def test_rayjob_init_validation_both_provided():
         )
 
 
-def test_rayjob_init_validation_neither_provided():
+def test_rayjob_init_validation_neither_provided(mocker):
     """Test that providing neither cluster_name nor cluster_config raises error."""
+    # Mock kubernetes config loading (though this should fail before reaching it)
+    mocker.patch("kubernetes.config.load_kube_config")
+    
+    # Mock the RayjobApi class entirely (though this should fail before reaching it)
+    mocker.patch("codeflare_sdk.ray.rayjobs.rayjob.RayjobApi")
+    
     with pytest.raises(
         ValueError, match="Either cluster_name or cluster_config must be provided"
     ):
         RayJob(job_name="test-job", entrypoint="python script.py")
 
 
-def test_rayjob_init_with_cluster_config():
+def test_rayjob_init_with_cluster_config(mocker):
     """Test RayJob initialization with cluster configuration for auto-creation."""
+    # Mock kubernetes config loading
+    mocker.patch("kubernetes.config.load_kube_config")
+    
+    # Mock the RayjobApi class entirely
+    mocker.patch("codeflare_sdk.ray.rayjobs.rayjob.RayjobApi")
+    
     cluster_config = ClusterConfiguration(
         name="auto-cluster", namespace="test-namespace", num_workers=2
     )
@@ -130,8 +148,14 @@ def test_rayjob_init_with_cluster_config():
     assert rayjob._cluster_name is None
 
 
-def test_rayjob_cluster_name_generation():
+def test_rayjob_cluster_name_generation(mocker):
     """Test that cluster names are generated when config has empty name."""
+    # Mock kubernetes config loading
+    mocker.patch("kubernetes.config.load_kube_config")
+    
+    # Mock the RayjobApi class entirely
+    mocker.patch("codeflare_sdk.ray.rayjobs.rayjob.RayjobApi")
+    
     cluster_config = ClusterConfiguration(
         name="",  # Empty name should trigger generation
         namespace="test-namespace",
@@ -150,6 +174,9 @@ def test_rayjob_cluster_name_generation():
 def test_build_ray_cluster_spec(mock_build_ray_cluster, mocker):
     """Test _build_ray_cluster_spec method."""
     mocker.patch("kubernetes.config.load_kube_config")
+    
+    # Mock the RayjobApi class entirely
+    mocker.patch("codeflare_sdk.ray.rayjobs.rayjob.RayjobApi")
 
     mock_ray_cluster = {
         "apiVersion": "ray.io/v1",
@@ -189,6 +216,9 @@ def test_build_ray_cluster_spec(mock_build_ray_cluster, mocker):
 def test_build_rayjob_cr_with_existing_cluster(mocker):
     """Test _build_rayjob_cr method with existing cluster."""
     mocker.patch("kubernetes.config.load_kube_config")
+    
+    # Mock the RayjobApi class entirely
+    mocker.patch("codeflare_sdk.ray.rayjobs.rayjob.RayjobApi")
 
     rayjob = RayJob(
         job_name="test-job",
@@ -221,6 +251,9 @@ def test_build_rayjob_cr_with_existing_cluster(mocker):
 def test_build_rayjob_cr_with_auto_cluster(mock_build_ray_cluster, mocker):
     """Test _build_rayjob_cr method with auto-created cluster."""
     mocker.patch("kubernetes.config.load_kube_config")
+    
+    # Mock the RayjobApi class entirely
+    mocker.patch("codeflare_sdk.ray.rayjobs.rayjob.RayjobApi")
 
     mock_ray_cluster = {
         "apiVersion": "ray.io/v1",
@@ -270,6 +303,9 @@ def test_submit_validation_no_entrypoint(mocker):
 def test_submit_with_auto_cluster(mock_build_ray_cluster, mocker):
     """Test successful submission with auto-created cluster."""
     mocker.patch("kubernetes.config.load_kube_config")
+    
+    # Mock the RayjobApi class entirely
+    mocker.patch("codeflare_sdk.ray.rayjobs.rayjob.RayjobApi")
 
     mock_ray_cluster = {
         "apiVersion": "ray.io/v1",