task(RHOAIENG-30722):Update code coverage

Author: LilyLinh

src/codeflare_sdk/ray/cluster/test_cluster.py

@@ -37,6 +37,7 @@
 from unittest.mock import MagicMock
 from kubernetes import client
 import yaml
+import pytest
 import filecmp
 import os
 
@@ -770,6 +771,132 @@ def custom_side_effect(group, version, namespace, plural, **kwargs):
     assert result.dashboard == rc_dashboard
 
 
+def test_throw_for_no_raycluster_crd_errors(mocker):
+    """Test RayCluster CRD error handling"""
+    from kubernetes.client.rest import ApiException
+    
+    mocker.patch("kubernetes.config.load_kube_config", return_value="ignore")
+    
+    # Test 404 error - CRD not found
+    mock_api_404 = MagicMock()
+    mock_api_404.list_namespaced_custom_object.side_effect = ApiException(status=404)
+    mocker.patch("kubernetes.client.CustomObjectsApi", return_value=mock_api_404)
+    
+    cluster = create_cluster(mocker)
+    with pytest.raises(RuntimeError, match="RayCluster CustomResourceDefinition unavailable"):
+        cluster._throw_for_no_raycluster()
+    
+    # Test other API error
+    mock_api_500 = MagicMock()
+    mock_api_500.list_namespaced_custom_object.side_effect = ApiException(status=500)
+    mocker.patch("kubernetes.client.CustomObjectsApi", return_value=mock_api_500)
+    
+    cluster2 = create_cluster(mocker)
+    with pytest.raises(RuntimeError, match="Failed to get RayCluster CustomResourceDefinition"):
+        cluster2._throw_for_no_raycluster()
+
+
+def test_cluster_apply_attribute_error_handling(mocker):
+    """Test AttributeError handling when DynamicClient fails"""
+    mocker.patch("kubernetes.config.load_kube_config", return_value="ignore")
+    mocker.patch("codeflare_sdk.ray.cluster.cluster.Cluster._throw_for_no_raycluster")
+    mocker.patch(
+        "kubernetes.client.CustomObjectsApi.list_namespaced_custom_object",
+        return_value=get_local_queue("kueue.x-k8s.io", "v1beta1", "ns", "localqueues"),
+    )
+    
+    # Mock get_dynamic_client to raise AttributeError
+    def raise_attribute_error():
+        raise AttributeError("DynamicClient initialization failed")
+    
+    mocker.patch(
+        "codeflare_sdk.ray.cluster.cluster.Cluster.get_dynamic_client",
+        side_effect=raise_attribute_error
+    )
+    
+    cluster = create_cluster(mocker)
+    
+    with pytest.raises(RuntimeError, match="Failed to initialize DynamicClient"):
+        cluster.apply()
+
+
+def test_cluster_namespace_handling(mocker, capsys):
+    """Test namespace validation in create_resource"""
+    mocker.patch("kubernetes.config.load_kube_config", return_value="ignore")
+    mocker.patch(
+        "kubernetes.client.CustomObjectsApi.list_namespaced_custom_object",
+        return_value=get_local_queue("kueue.x-k8s.io", "v1beta1", "ns", "localqueues"),
+    )
+    
+    # Test with None namespace that gets set
+    mocker.patch(
+        "codeflare_sdk.ray.cluster.cluster.get_current_namespace",
+        return_value=None
+    )
+    
+    config = ClusterConfiguration(
+        name="test-cluster-ns",
+        namespace=None,  # Will trigger namespace check
+        num_workers=1,
+        worker_cpu_requests=1,
+        worker_cpu_limits=1,
+        worker_memory_requests=2,
+        worker_memory_limits=2,
+    )
+    
+    cluster = Cluster(config)
+    captured = capsys.readouterr()
+    # Verify the warning message was printed
+    assert "Please specify with namespace=<your_current_namespace>" in captured.out
+    assert cluster.config.namespace is None
+
+
+def test_cluster_up_with_write_to_file(mocker):
+    """Test cluster.up() method with write_to_file enabled"""
+    mocker.patch("kubernetes.config.load_kube_config", return_value="ignore")
+    mocker.patch("codeflare_sdk.ray.cluster.cluster.Cluster._throw_for_no_raycluster")
+    mocker.patch("codeflare_sdk.ray.cluster.cluster.config_check")
+    mocker.patch(
+        "kubernetes.client.CustomObjectsApi.list_namespaced_custom_object",
+        return_value=get_local_queue("kueue.x-k8s.io", "v1beta1", "ns", "localqueues"),
+    )
+    
+    # Mock the create_namespaced_custom_object
+    mock_create = MagicMock()
+    mocker.patch(
+        "kubernetes.client.CustomObjectsApi.create_namespaced_custom_object",
+        return_value=mock_create
+    )
+    
+    # Create cluster with write_to_file=True
+    config = ClusterConfiguration(
+        name="test-cluster-up",
+        namespace="ns",
+        num_workers=1,
+        worker_cpu_requests=1,
+        worker_cpu_limits=1,
+        worker_memory_requests=2,
+        worker_memory_limits=2,
+        write_to_file=True,
+        appwrapper=True,
+    )
+    
+    cluster = Cluster(config)
+    
+    # Mock file reading
+    import tempfile
+    import os
+    with tempfile.NamedTemporaryFile(mode='w', suffix='.yaml', delete=False) as f:
+        f.write('apiVersion: v1\nkind: ConfigMap\nmetadata:\n  name: test')
+        temp_file = f.name
+    
+    try:
+        cluster.resource_yaml = temp_file
+        cluster.up()
+    finally:
+        os.unlink(temp_file)
+
+
 # Make sure to always keep this function last
 def test_cleanup():
     os.remove(f"{aw_dir}test-all-params.yaml")