wrap api client to add defaults #669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-merge-robot
added
the
needs-rebase
KPostOffice
force-pushed
the
wrap-login
branch
from
fe75256 to
5db43fb
Compare
openshift-merge-robot
removed
the
needs-rebase
KPostOffice
force-pushed
the
wrap-login
branch
2 times, most recently
from
bbc8b79 to
d8b37c6
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
KPostOffice
force-pushed
the
wrap-login
branch
from
d8b37c6 to
97436b4
Compare
ChristianZaccaria
previously requested changes
Sep 24, 2024
Contributor
ChristianZaccaria
left a comment
ChristianZaccaria
left a comment
There was a problem hiding this comment.
Looks great! - Just a few fixes
KPostOffice
force-pushed
the
wrap-login
branch
3 times, most recently
from
19c2abe to
8d655e2
Compare
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
KPostOffice
force-pushed
the
wrap-login
branch
from
873398e to
7567f22
Compare
Signed-off-by: Kevin <[email protected]>
KPostOffice
force-pushed
the
wrap-login
branch
from
7567f22 to
103e805
Compare
openshift-ci
bot
added
lgtm
ChristianZaccaria
approved these changes
Sep 27, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobbins228, ChristianZaccaria The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 1a95a15
into
project-codeflare:main
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
https://issues.redhat.com/browse/RHOAIENG-12802
What changes have been made
If the user logged in using
oc login ...the self signed CA cert wasn't being picked upVerification steps
Use
oc loginin a ODH cluster with self signed certs. The user should be able to create Ray Clusters without doing anything specialChecks