Merge branch 'opendatahub-io-main'

Author: Mohammed Abdi

.env

@@ -11,8 +11,9 @@
 ############### Default settings ###############
 BACKEND_PORT=8080
 IMAGE_REPOSITORY=quay.io/opendatahub/odh-dashboard:nightly
-DOC_LINK ='https://opendatahub.io/docs.html'
-COMMUNITY_LINK ='https://opendatahub.io/community.html'
+DOC_LINK ='https://opendatahub.io/docs'
+COMMUNITY_LINK ='https://opendatahub.io/community'
 ENABLED_APPS_CM = 'odh-enabled-applications-config'
 KUSTOMIZE_MANIFEST_DIR=manifests
+KUSTOMIZE_DEFAULT_OVERLAY=/overlays/dev
 DASHBOARD_CONFIG = 'odh-dashboard-config'

.github/ISSUE_TEMPLATE/bug_report.yaml

@@ -1,7 +1,7 @@
 name: Bug Report
-description: File a bug report
+description: File a bug report.
 title: "[Bug]: "
-labels: ["kind/bug", "untriaged"]
+labels: ["kind/bug", "priority/normal", "untriaged"]
 body:
   - type: markdown
     attributes:
@@ -12,8 +12,30 @@ body:
       label: Is there an existing issue for this?
       description: Please search to see if an issue already exists for the bug you encountered.
       options:
-      - label: I have searched the existing issues
-        required: true
+        - label: I have searched the existing issues
+          required: true
+  - type: dropdown
+    id: deploy-type
+    attributes:
+      label: Deploy type
+      description: How did you deploy the Dashboard?
+      multiple: false
+      options:
+        - OpenDataHub core version (eg. `v1.6.0`)
+        - Installing Dashboard directly (eg. `v2.12.0`, `commit xyz`, `branch name`)
+        - Downstream version (eg. `RHODS 1.29`)
+    validations:
+      required: true
+  - type: input
+    id: version
+    attributes:
+      label: Version
+      description: |
+        What was the version this was found on?
+        
+        eg. a branch name, a commit id, or a version number
+    validations:
+      required: true
   - type: textarea
     attributes:
       label: Current Behavior
@@ -55,12 +77,6 @@ body:
         - Microsoft Edge
     validations:
       required: false
-  - type: textarea
-    id: opendatahub-version
-    attributes:
-      label: Open Data Hub Version
-      description: Please attach relevant kfdef manifest if applicable
-      render: yml
   - type: textarea
     id: anything-else
     attributes:

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -1,7 +1,7 @@
 name: Feature request
-description: Suggest an idea for this project
+description: Suggest an idea for this project.
 title: "[Feature Request]: "
-labels: ["kind/enhancement", "untriaged"]
+labels: ["kind/enhancement", "priority/normal", "untriaged"]
 body:
   - type: markdown
     attributes:

.github/ISSUE_TEMPLATE/internal_story.yml

@@ -1,6 +1,7 @@
 name: (Internal) Feature Story Template
-description: Intended to help with a template for breaking down larger efforts
-labels: ["priority/high"]
+description: Intended to help with a template for breaking down larger efforts.
+title: "[Story]: "
+labels: ["kind/story", "priority/high"]
 body:
   - type: input
     id: goal

.github/ISSUE_TEMPLATE/internal_test.yml

@@ -0,0 +1,52 @@
+name: (Internal) Test Template
+description: Intended to help with a template for creating issues for test coverage.
+title: "[Test]: "
+labels: ["kind/tech-debt", "priority/normal", "quality"]
+body:
+  - type: input
+    id: description
+    attributes:
+      label: Description
+      description: A high level goal for the test.
+      placeholder: Tests the global <feature> page.
+    validations:
+      required: true
+  - type: dropdown
+    id: type
+    attributes:
+      label: What type of test is it?
+      multiple: false
+      options:
+        - e2e (user flow, server data test)
+        - integration (test data, UI rendering)
+        - unit (functional test)
+    validations:
+      required: true
+  - type: textarea
+    id: goals
+    attributes:
+      label: Test goals
+      description: |
+        Describe the test coverage goals / acceptance criteria.
+
+        Eg. what tests are expected / what is the full path for e2e test / what utils are to be tested / etc
+      placeholder: |
+        * Test page xyz
+        * Handle empty states
+        * etc...
+    validations:
+      required: true
+  - type: textarea
+    id: dependencies
+    attributes:
+      label: Related tests
+      description: |
+        A link to related test stories to help with sizing the work
+
+        Tip: Using a bullet list will help display links to other tickets by unraveling the name and status of that ticket.
+      placeholder: |
+        * #xxxx1
+        * #xxxx2
+      value: No related tests
+    validations:
+      required: false

.github/pull_request_template.md

@@ -1,3 +1,4 @@
+<!--- If this is a non-code change, this template is not required; reference any issues or top-level descriptions as needed -->
 <!--- All code change PRs should relate to an issue, reference it here; see example below -->
 <!--- Closes: #123 -->
 
@@ -18,9 +19,16 @@
 <!--- This PR will be merged by any repository approver when it meets all the points in the checklist -->
 <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
 
-- [ ] The commits have meaningful messages (squashes happen on merge by the bot).
-- [ ] Included any necessary screenshots or gifs if it was a UI change.
-- [ ] Included tags to the UX team if it was a UI/UX change.
-- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
+Self checklist (all need to be checked):
 - [ ] The developer has manually tested the changes and verified that the changes work
+- [ ] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
+- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
 - [ ] The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)
+
+If you have UI changes: 
+<!--- You can ignore these if you are doing manifest, backend, internal logic, etc changes; aka non-UI / visual changes -->
+- [ ] Included any necessary screenshots or gifs if it was a UI change.
+- [ ] Included tags to the UX team if it was a UI/UX change.
+
+After the PR is posted & before it merges:
+- [ ] The developer has tested their solution on a cluster by using the image produced by the PR to `main`

.github/trivy.yaml

@@ -0,0 +1,4 @@
+format: sarif
+exit-code: 0
+severity: 'CRITICAL,HIGH'
+output: 'scan_result.sarif'

.github/workflows/pull_request.yml

@@ -4,15 +4,15 @@ on:
     branches: [ main, f/** ]
 
 jobs:
-  Integration-checks:
+  Tests:
     runs-on: ubuntu-latest
     strategy:
       matrix:
         node-version: [18.x]
     steps:
       - uses: actions/checkout@v3
       - name: Setup Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3.6.0
+        uses: actions/setup-node@v3.7.0
         with:
           node-version: ${{ matrix.node-version }}
       - name: Node.js modules cache, repository
@@ -42,6 +42,9 @@ jobs:
       - name: Install Node.js packages
         if: ${{ steps.repo-cache.outputs.cache-hit != 'true' || steps.backend-cache.outputs.cache-hit != 'true' || steps.frontend-cache.outputs.cache-hit != 'true' }}
         run: npm install
+      - name: Install Playwright Browsers
+        working-directory: ./frontend
+        run: npx playwright install --with-deps
       - name: Test
         if: ${{ success() }}
         run: npm run test

.github/workflows/storybook-tests.yml

@@ -0,0 +1,29 @@
+name: Value Scan
+
+on:
+  pull_request:
+
+jobs:
+  scan:
+    name: Scan Files
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: Run Trivy vulnerability scanner for filesystem
+        uses: aquasecurity/[email protected]
+        with:
+          scan-type: 'fs'
+          scan-ref: '.'
+          trivy-config: .github/trivy.yaml
+
+      - name: Upload Trivy scan results to GitHub Security tab
+        uses: github/codeql-action/upload-sarif@v2
+        with:
+          sarif_file: 'scan_result.sarif'
+
+      - name: Archive scan results to GitHub
+        uses: actions/upload-artifact@v3
+        with:
+          name: trivyResult
+          path: 'scan_result.sarif'
+          if-no-files-found: error