bugfix: proper handling of values set to 0

`if .Values.X` evaluates to false if X is defined to be 0.
This resulted in retryLimit and terminationGracePeriodSeconds
not being properly propagated through the the generated yaml
if the user sets their value to 0 (as opposed to nil).

Author: dgrove-oss

tools/pytorchjob-generator/chart/templates/_helpers.tpl

@@ -29,7 +29,7 @@ annotations:
 
 
 {{- define "mlbatch.schedulingSpec" }}
-{{- if .Values.terminationGracePeriodSeconds }}
+{{- if ne .Values.terminationGracePeriodSeconds nil }}
 terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds }}
 {{- end }}
 {{- if .Values.bypassCoscheduler }}

tools/pytorchjob-generator/chart/templates/appwrapper.yaml

@@ -67,7 +67,7 @@ metadata:
         {{- if .Values.retryPausePeriodDuration }}
         workload.codeflare.dev.appwrapper/retryPausePeriodDuration: "{{ .Values.retryPausePeriodDuration }}"
         {{- end }}
-        {{- if .Values.retryLimit }}
+        {{- if ne .Values.retryLimit nil }}
         workload.codeflare.dev.appwrapper/retryLimit: "{{ .Values.retryLimit }}"
         {{- end }}
         {{- if .Values.forcefulDeletionGracePeriodDuration }}

tools/pytorchjob-generator/chart/tests/helloworld_test.yaml

@@ -164,6 +164,22 @@ tests:
         workload.codeflare.dev.appwrapper/forcefulDeletionGracePeriodDuration: "19s"
         workload.codeflare.dev.appwrapper/deletionOnFailureGracePeriodDuration: "2s"
 
+- it: Setting integer fault tolerance annotation to 0
+  set:
+    retryLimit: 0
+    terminationGracePeriodSeconds: 0
+  asserts:
+  - isSubset:
+      path: metadata.annotations
+      content:
+        workload.codeflare.dev.appwrapper/retryLimit: "0"
+  - equal:
+      path: spec.components[0].template.spec.pytorchReplicaSpecs.Master.template.spec.terminationGracePeriodSeconds
+      value: 0
+  - equal:
+      path: spec.components[0].template.spec.pytorchReplicaSpecs.Worker.template.spec.terminationGracePeriodSeconds
+      value: 0
+
 - it: Setting just one tolerance annotation
   set:
     deletionOnFailureGracePeriodDuration: "6h"