Skip to content

Commit 396e9e2

Browse files
ChristianZaccariaChristianZaccaria
committed
Change label name to workload.codeflare.dev
1 parent 945df9d commit 396e9e2

33 files changed

+116
-116
lines changed

‎doc/usage/tutorial.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ Delete the first `AppWrapper` job.
312312

313313
```bash
314314
$ kubectl delete -f aw-01.yaml
315-
appwrapper.workload.codeflare.dev "0001-aw-generic-deployment-1" deleted
315+
workload.codeflare.dev/appwrapper "0001-aw-generic-deployment-1" deleted
316316
```
317317

318318
Check the pods status of the `AppWrapper` jobs. The new pods from the second `AppWrapper` job: `0002-aw-generic-deployment-2` job should now be deployed and running.

‎pkg/apis/controller/v1beta1/appwrapper.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ const AppWrapperPlural string = "appwrappers"
2626

2727
// AppWrapperAnnotationKey is the annotation key of Pod to identify
2828
// which AppWrapper it belongs to.
29-
const AppWrapperAnnotationKey = "appwrapper.mcad.ibm.com/appwrapper-name"
29+
const AppWrapperAnnotationKey = "workload.codeflare.dev/appwrapper-name"
3030

3131
// +genclient
3232
// +kubebuilder:object:root=true

‎pkg/controller/queuejob/queuejob_controller_ex.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ func GetQueueJobKey(obj interface{}) (string, error) {
144144
// UpdateQueueJobStatus was part of pod informer, this is now a method of queuejob_controller file.
145145
// This change is done in an effort to simplify the controller and enable to move to controller runtime.
146146
func (qjm *XController) UpdateQueueJobStatus(queuejob *arbv1.AppWrapper) error {
147-
labelSelector := fmt.Sprintf("%s=%s", "appwrapper.mcad.ibm.com", queuejob.Name)
147+
labelSelector := fmt.Sprintf("%s=%s", "workload.codeflare.dev/appwrapper", queuejob.Name)
148148
pods, errt := qjm.clients.CoreV1().Pods("").List(context.TODO(), metav1.ListOptions{LabelSelector: labelSelector})
149149
if errt != nil {
150150
return errt
@@ -209,7 +209,7 @@ func (qjm *XController) allocatableCapacity() *clusterstateapi.Resource {
209209
klog.Errorf("[allocatableCapacity] Error listing pods %v", err)
210210
}
211211
for _, pod := range podList.Items {
212-
if _, ok := pod.GetLabels()["appwrappers.mcad.ibm.com"]; !ok && pod.Status.Phase != v1.PodFailed && pod.Status.Phase != v1.PodSucceeded {
212+
if _, ok := pod.GetLabels()["workload.codeflare.dev/appwrappers"]; !ok && pod.Status.Phase != v1.PodFailed && pod.Status.Phase != v1.PodSucceeded {
213213
for _, container := range pod.Spec.Containers {
214214
usedResource := clusterstateapi.NewResource(container.Resources.Requests)
215215
capacity.Sub(usedResource)

‎pkg/controller/queuejobresources/genericresource/genericresource.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ import (
4343
"k8s.io/client-go/restmapper"
4444
)
4545

46-
var appwrapperJobLabelName = "appwrapper.mcad.ibm.com"
47-
var appwrapperJobLabelNamespace = "appwrapper.mcad.ibm.com/namespace"
48-
var resourceName = "resourceName"
46+
var appwrapperJobLabelName = "workload.codeflare.dev/appwrapper"
47+
var appwrapperJobLabelNamespace = "workload.codeflare.dev/appwrapper/namespace"
48+
var resourceName = "workload.codeflare.dev/resourceName"
4949
var appWrapperKind = arbv1.SchemeGroupVersion.WithKind("AppWrapper")
5050

5151
type GenericResources struct {

‎test/e2e-kuttl-borrowing/steps/03-install.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ spec:
3131
name: my-job-1
3232
namespace: test
3333
labels:
34-
appwrapper.mcad.ibm.com: my-job-1
34+
workload.codeflare.dev/appwrapper: my-job-1
3535
spec:
3636
parallelism: 1
3737
completions: 1
@@ -40,7 +40,7 @@ spec:
4040
name: my-job-1
4141
namespace: test
4242
labels:
43-
appwrapper.mcad.ibm.com: my-job-1
43+
workload.codeflare.dev/appwrapper: my-job-1
4444
spec:
4545
terminationGracePeriodSeconds: 1
4646
restartPolicy: Never

‎test/e2e-kuttl-borrowing/steps/04-install.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ spec:
3131
name: my-job-2
3232
namespace: test
3333
labels:
34-
appwrapper.mcad.ibm.com: my-job-2
34+
workload.codeflare.dev/appwrapper: my-job-2
3535
spec:
3636
parallelism: 1
3737
completions: 1
@@ -40,7 +40,7 @@ spec:
4040
name: my-job-2
4141
namespace: test
4242
labels:
43-
appwrapper.mcad.ibm.com: my-job-2
43+
workload.codeflare.dev/appwrapper: my-job-2
4444
spec:
4545
terminationGracePeriodSeconds: 1
4646
restartPolicy: Never

‎test/e2e-kuttl-deployment-01/steps/01-assert.yaml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ metadata:
1414
namespace: start-up
1515
labels:
1616
app: no-quota-deployment-01
17-
appwrapper.mcad.ibm.com: no-quota-deployment-01
18-
appwrapper.mcad.ibm.com/namespace: start-up
19-
resourceName: no-quota-deployment-01
17+
workload.codeflare.dev/appwrapper: no-quota-deployment-01
18+
workload.codeflare.dev/appwrapper/namespace: start-up
19+
workload.codeflare.dev/resourceName: no-quota-deployment-01
2020
status:
2121
availableReplicas: 1
2222
observedGeneration: 1

‎test/e2e-kuttl-deployment-01/steps/02-install.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ spec:
2727
name: no-quota-job-02
2828
namespace: start-up
2929
labels:
30-
appwrapper.mcad.ibm.com: no-quota-job-02
30+
workload.codeflare.dev/appwrapper: no-quota-job-02
3131
spec:
3232
parallelism: 1
3333
completions: 1
@@ -36,7 +36,7 @@ spec:
3636
name: no-quota-job-1
3737
namespace: start-up
3838
labels:
39-
appwrapper.mcad.ibm.com: no-quota-job-02
39+
workload.codeflare.dev/appwrapper: no-quota-job-02
4040
spec:
4141
terminationGracePeriodSeconds: 1
4242
restartPolicy: Never

‎test/e2e-kuttl-deployment-01/steps/03-assert.yaml‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ metadata:
1212
name: hold-completion-job-03-01
1313
namespace: start-up
1414
labels:
15-
appwrapper.mcad.ibm.com: hold-completion-job-03
16-
appwrapper.mcad.ibm.com/namespace: start-up
17-
resourceName: hold-completion-job-03-01
15+
workload.codeflare.dev/appwrapper: hold-completion-job-03
16+
workload.codeflare.dev/appwrapper/namespace: start-up
17+
workload.codeflare.dev/resourceName: hold-completion-job-03-01
1818
status:
1919
conditions:
2020
- status: "True"
@@ -26,17 +26,17 @@ kind: Pod
2626
metadata:
2727
namespace: start-up
2828
labels:
29-
appwrapper.mcad.ibm.com: hold-completion-job-03
30-
appwrapper.mcad.ibm.com/namespace: start-up
29+
workload.codeflare.dev/appwrapper: hold-completion-job-03
30+
workload.codeflare.dev/appwrapper/namespace: start-up
3131
job-name: hold-completion-job-03-01
32-
resourceName: hold-completion-job-03-01
32+
workload.codeflare.dev/resourceName: hold-completion-job-03-01
3333
---
3434
apiVersion: v1
3535
kind: Pod
3636
metadata:
3737
namespace: start-up
3838
labels:
39-
appwrapper.mcad.ibm.com: hold-completion-job-03
40-
appwrapper.mcad.ibm.com/namespace: start-up
39+
workload.codeflare.dev/appwrapper: hold-completion-job-03
40+
workload.codeflare.dev/appwrapper/namespace: start-up
4141
job-name: hold-completion-job-03-02
42-
resourceName: hold-completion-job-03-02
42+
workload.codeflare.dev/resourceName: hold-completion-job-03-02

‎test/e2e-kuttl-deployment-01/steps/03-install.yaml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ spec:
3131
name: hold-completion-job-03-01
3232
namespace: start-up
3333
labels:
34-
appwrapper.mcad.ibm.com: hold-completion-job-03
34+
workload.codeflare.dev/appwrapper: hold-completion-job-03
3535
spec:
3636
parallelism: 1
3737
completions: 1
@@ -40,7 +40,7 @@ spec:
4040
name: hold-completion-job-03-01
4141
namespace: start-up
4242
labels:
43-
appwrapper.mcad.ibm.com: hold-completion-job-03
43+
workload.codeflare.dev/appwrapper: hold-completion-job-03
4444
spec:
4545
terminationGracePeriodSeconds: 1
4646
restartPolicy: Never
@@ -80,7 +80,7 @@ spec:
8080
name: hold-completion-job-03-02
8181
namespace: start-up
8282
labels:
83-
appwrapper.mcad.ibm.com: hold-completion-job-03
83+
workload.codeflare.dev/appwrapper: hold-completion-job-03
8484
spec:
8585
parallelism: 1
8686
completions: 1
@@ -89,7 +89,7 @@ spec:
8989
name: hold-completion-job-03-02
9090
namespace: start-up
9191
labels:
92-
appwrapper.mcad.ibm.com: hold-completion-job-03
92+
workload.codeflare.dev/appwrapper: hold-completion-job-03
9393
spec:
9494
terminationGracePeriodSeconds: 1
9595
restartPolicy: Never

0 commit comments

Comments
 (0)