Skip to content

Commit 6a7c254

Browse files
asm582openshift-merge-robot
authored andcommitted
add todos
1 parent c03e7ee commit 6a7c254

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

pkg/controller/queuejob/queuejob_controller_ex.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,7 @@ func NewJobController(config *rest.Config, serverOption *options.ServerOption) *
169169
cache: clusterstatecache.New(config),
170170
schedulingAW: nil,
171171
}
172+
//TODO: work on enabling metrics adapter for correct MCAD mode
172173
//metrics adapter is implemented through dynamic client which looks at all the
173174
//resources installed in the cluster to construct cache. May be this is need in
174175
//multi-cluster mode, so for now it is turned-off
@@ -1245,7 +1246,7 @@ func (qjm *XController) ScheduleNext(qj *arbv1.AppWrapper) {
12451246
go qjm.backoff(ctx, qj, dispatchFailedReason, dispatchFailedMessage)
12461247
}
12471248
// if the HeadOfLineHoldingTime option is not set it will break the loop
1248-
//schedulingTimeExpired := time.Now().After(HOLStartTime.Add(time.Duration(qjm.serverOption.HeadOfLineHoldingTime) * time.Second))
1249+
//TODO: Remove schedulingTimeExpired flag
12491250
schedulingTimeExpired := false
12501251
if forwarded {
12511252
break

0 commit comments

Comments
 (0)