fix build

Author: asm582

pkg/controller/clusterstate/cache/cache.go

@@ -34,7 +34,6 @@ import (
 	"context"
 	"fmt"
 	"sync"
-	"time"
 
 	"github.com/golang/protobuf/proto"
 	dto "github.com/prometheus/client_model/go"
@@ -102,7 +101,7 @@ func (sc *ClusterStateCache) Run(stopCh <-chan struct{}) {
 	go sc.nodeInformer.Informer().Run(stopCh)
 
 	// Update cache
-	go wait.Until(sc.updateCache, 1*time.Second, stopCh)
+	go wait.Until(sc.updateCache, 0, stopCh)
 
 }
 

pkg/controller/queuejob/queuejob_controller_ex.go

@@ -1111,8 +1111,21 @@ func (qjm *XController) ScheduleNext(qj *arbv1.AppWrapper) {
 				if qjm.serverOption.DynamicPriority {
 					priorityindex = -math.MaxFloat64
 				}
+				//cache.go updatestate method fails resulting in empty resource object
+				//cache upate failure costly, as it will put current AW in backoff queue plus take another dispatch cycle
+				//In worst case the cache update could fail for subsequent dispatche cycles causing test cases to fail or AW never getting dispatched
+				//To avoid non-determinism below code is workaround. this should be issue should be fixed: https://github.com/project-codeflare/multi-cluster-app-dispatcher/issues/550
+				var unallocatedResources = clusterstateapi.EmptyResource()
+				unallocatedResources = qjm.cache.GetUnallocatedResources()
+				for unallocatedResources.IsEmpty() {
+					unallocatedResources.Add(qjm.cache.GetUnallocatedResources())
+					if !unallocatedResources.IsEmpty() {
+						break
+					}
+				}
+
 				resources, proposedPreemptions := qjm.getAggregatedAvailableResourcesPriority(
-					qjm.cache.GetUnallocatedResources(), priorityindex, qj, "")
+					unallocatedResources, priorityindex, qj, "")
 				klog.Infof("[ScheduleNext] [Agent Mode] Appwrapper '%s/%s' with resources %v to be scheduled on aggregated idle resources %v", qj.Namespace, qj.Name, aggqj, resources)
 
 				// Assume preemption will remove low priroity AWs in the system, optimistically dispatch such AWs

test/e2e/util.go

@@ -1918,16 +1918,12 @@ func createGenericNamespaceAW(context *context, name string) *arbv1.AppWrapper {
 			"app": "aw-generic-namespace-0"
 		}
 	}} `)
-	var schedSpecMin int = 0
 
 	aw := &arbv1.AppWrapper{
 		ObjectMeta: metav1.ObjectMeta{
 			Name: name,
 		},
 		Spec: arbv1.AppWrapperSpec{
-			SchedSpec: arbv1.SchedulingSpecTemplate{
-				MinAvailable: schedSpecMin,
-			},
 			AggrResources: arbv1.AppWrapperResourceList{
 				GenericItems: []arbv1.AppWrapperGenericResource{
 					{