fix: tag rate limit — single bucket per schema and throttle on OCP All endpoints (#5913)

Author: bacciotti

koku/api/common/test_throttling.py

@@ -89,8 +89,7 @@ def test_get_cache_key_success_returns_key(self, mock_flag):
         }
         key = throttle.get_cache_key(request, None)
         self.assertIsNotNone(key)
-        self.assertIn("tag_query_throttle:acct123:", key)
-        self.assertIn("group_by[tag:app]", key)
+        self.assertEqual(key, "tag_query_throttle:acct123")
 
 
 class TagQueryThrottleGetDateRangeDaysTest(TestCase):

koku/api/common/throttling.py

@@ -74,9 +74,9 @@ def get_cache_key(self, request, view):
             # Limit the need to check unleash by calling it last
             return None
 
-        # Build cache key: schema + sorted tag keys
-        tag_keys_str = ",".join(sorted(tag_keys))
-        cache_key = f"tag_query_throttle:{schema_name}:{tag_keys_str}"
+        # One bucket per schema: 1 heavy tag query per 12h total, regardless of which tag key.
+        # (Previously we keyed by schema + tag_keys, allowing 1 per 12h per tag = multiple slots.)
+        cache_key = f"tag_query_throttle:{schema_name}"
 
         LOG.debug(f"Tag query throttle check: {cache_key}, date_range: {date_range_days} days")
         return cache_key

koku/api/report/all/openshift/view.py

@@ -4,6 +4,7 @@
 #
 """View for OpenShift on All infrastructure Usage Reports."""
 from api.common.permissions.openshift_all_access import OpenshiftAllAccessPermission
+from api.common.throttling import TagQueryThrottle
 from api.models import Provider
 from api.report.all.openshift.query_handler import OCPAllReportQueryHandler
 from api.report.all.openshift.serializers import OCPAllQueryParamSerializer
@@ -14,6 +15,7 @@ class OCPAllView(ReportView):
     """OCP on All Infrastructure Base View."""
 
     permission_classes = [OpenshiftAllAccessPermission]
+    throttle_classes = [TagQueryThrottle]
     provider = Provider.OCP_ALL
     serializer = OCPAllQueryParamSerializer
     query_handler = OCPAllReportQueryHandler