Skip to content

Commit 938d3dd

Browse files
shankarapailoorRaghav Malik
authored andcommitted
Shankara/pcl include fix (#221)
* used the wrong cmake flag when guarding PCL imports
1 parent ba2e61e commit 938d3dd

File tree

4 files changed

+5
-3
lines changed

4 files changed

+5
-3
lines changed
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
fixed:
2+
- Used the wrong PCL guard variable in CMakeLists.txt.

include/llzk/Transforms/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
include_directories(${MLIR_INCLUDE_DIRS} ${LLZK_INCLUDE_DIR})
22

33
set(_TBLGEN_PCL_FLAG "")
4-
if(LLZK_WITH_PCL)
4+
if(LLZK_WITH_PCL_BOOL)
55
set(_TBLGEN_PCL_FLAG "-DWITH_PCL")
66
endif()
77

lib/Transforms/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ add_library(LLZK::LLZKTransforms ALIAS LLZKTransforms)
44
file(GLOB LLZKTransforms_SOURCES "*.cpp")
55

66
# Remove the PCL lowering .cpp only when disabled.
7-
if(NOT LLZK_WITH_PCL)
7+
if(NOT LLZK_WITH_PCL_BOOL)
88
list(REMOVE_ITEM LLZKTransforms_SOURCES "${CMAKE_CURRENT_SOURCE_DIR}/LLZKPCLLoweringPass.cpp")
99
endif()
1010

test/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ set(LIT_ARGS "--xunit-xml-output report.xml")
2020
# creating this guard and setting to 0-1
2121
# because python doesn't like the ON/OFF stuff
2222
set(LLZK_WITH_PCL_GUARD 0)
23-
if(LLZK_WITH_PCL)
23+
if(LLZK_WITH_PCL_BOOL)
2424
set(LLZK_WITH_PCL_GUARD 1)
2525
endif()
2626

0 commit comments

Comments
 (0)