Skip to content

Investigate alternatives to ported SparseAnalysis #308

@iangneal

Description

@iangneal

In this PR: #307, we removed the ported DenseAnalysis since we no longer needed a custom implementation.

The SparseAnalysis was ported for a similar reason, but also has changes to the (non-virtual) visitOperation function so that operations without results (constraints, member writes, etc) are visited.

LogicalResult AbstractSparseForwardDataFlowAnalysis::visitOperation(Operation *op) {
/// LLZK: Visit operations with no results, as they may still affect values
/// (e.g., constraints and assertions).
/// The MLIR version doesn't visit result-less operations.

We can likely implement this functionality in a different way tnat allows us to remove this port.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions