From abf5089967408daf51cca82a3c0c21f680bcb503 Mon Sep 17 00:00:00 2001 From: shankarapailoor Date: Fri, 21 Nov 2025 10:52:20 -0600 Subject: [PATCH 1/2] used the wrong cmake flag when guarding PCL imports --- include/llzk/Transforms/CMakeLists.txt | 2 +- lib/Transforms/CMakeLists.txt | 2 +- test/CMakeLists.txt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/llzk/Transforms/CMakeLists.txt b/include/llzk/Transforms/CMakeLists.txt index 613950e73..72a346a09 100644 --- a/include/llzk/Transforms/CMakeLists.txt +++ b/include/llzk/Transforms/CMakeLists.txt @@ -1,7 +1,7 @@ include_directories(${MLIR_INCLUDE_DIRS} ${LLZK_INCLUDE_DIR}) set(_TBLGEN_PCL_FLAG "") -if(LLZK_WITH_PCL) +if(LLZK_WITH_PCL_BOOL) set(_TBLGEN_PCL_FLAG "-DWITH_PCL") endif() diff --git a/lib/Transforms/CMakeLists.txt b/lib/Transforms/CMakeLists.txt index f5e6ab3bf..22b0be34b 100644 --- a/lib/Transforms/CMakeLists.txt +++ b/lib/Transforms/CMakeLists.txt @@ -4,7 +4,7 @@ add_library(LLZK::LLZKTransforms ALIAS LLZKTransforms) file(GLOB LLZKTransforms_SOURCES "*.cpp") # Remove the PCL lowering .cpp only when disabled. -if(NOT LLZK_WITH_PCL) +if(NOT LLZK_WITH_PCL_BOOL) list(REMOVE_ITEM LLZKTransforms_SOURCES "${CMAKE_CURRENT_SOURCE_DIR}/LLZKPCLLoweringPass.cpp") endif() diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt index 0711bdbe8..07d49478a 100644 --- a/test/CMakeLists.txt +++ b/test/CMakeLists.txt @@ -20,7 +20,7 @@ set(LIT_ARGS "--xunit-xml-output report.xml") # creating this guard and setting to 0-1 # because python doesn't like the ON/OFF stuff set(LLZK_WITH_PCL_GUARD 0) -if(LLZK_WITH_PCL) +if(LLZK_WITH_PCL_BOOL) set(LLZK_WITH_PCL_GUARD 1) endif() From 531fa7ab115b5a82bf8a35543eca64bbcc9cde6a Mon Sep 17 00:00:00 2001 From: shankarapailoor Date: Fri, 21 Nov 2025 10:53:26 -0600 Subject: [PATCH 2/2] fixing pcl includes --- changelogs/unreleased/shankara__pcl-include-fix.yaml | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 changelogs/unreleased/shankara__pcl-include-fix.yaml diff --git a/changelogs/unreleased/shankara__pcl-include-fix.yaml b/changelogs/unreleased/shankara__pcl-include-fix.yaml new file mode 100644 index 000000000..0a0d23813 --- /dev/null +++ b/changelogs/unreleased/shankara__pcl-include-fix.yaml @@ -0,0 +1,2 @@ +fixed: + - Used the wrong PCL guard variable in CMakeLists.txt.