Return default avatar url when user id is zero rather than updating database (go-gitea#34094)

lunny · jerger · commit 02d9c7cd27e0 · 2025-04-07T16:48:15.000+02:00
(cherry picked from commit 88352e0)
diff --git a/models/user/avatar.go b/models/user/avatar.go
@@ -62,7 +62,7 @@ func GenerateRandomAvatar(ctx context.Context, u *User) error {
 
 // AvatarLinkWithSize returns a link to the user's avatar with size. size <= 0 means default size
 func (u *User) AvatarLinkWithSize(ctx context.Context, size int) string {
-	if u.IsGhost() {
+	if u.IsGhost() || u.ID <= 0 {
 		return avatars.DefaultAvatarLink()
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ func GenerateRandomAvatar(ctx context.Context, u *User) error {`
`62`	`62`
`63`	`63`	`// AvatarLinkWithSize returns a link to the user's avatar with size. size <= 0 means default size`
`64`	`64`	`func (u *User) AvatarLinkWithSize(ctx context.Context, size int) string {`
`65`		`- if u.IsGhost() {`
	`65`	`+ if u.IsGhost() \|\| u.ID <= 0 {`
`66`	`66`	`return avatars.DefaultAvatarLink()`
`67`	`67`	`}`
`68`	`68`