port(gitea): Retain issue/pull sort type (go-gitea#8067)

port of [gitea#34559](go-gitea#34559)

initial work attributed to [badhezi](https://github.com/badhezi)

Co-authored-by: badhezi <[email protected]>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8067
Reviewed-by: Beowulf <[email protected]>
Reviewed-by: Gusted <[email protected]>
Co-authored-by: Shiny Nematoda <[email protected]>
Co-committed-by: Shiny Nematoda <[email protected]>

Author: 2 people

templates/repo/issue/search.tmpl

@@ -8,6 +8,7 @@
 			<input type="hidden" name="project" value="{{$.ProjectID}}">
 			<input type="hidden" name="assignee" value="{{$.AssigneeID}}">
 			<input type="hidden" name="poster" value="{{$.PosterID}}">
+			<input type="hidden" name="sort" value="{{$.SortType}}">
 		{{end}}
 		{{if .PageIsPullList}}
 			{{template "shared/search/combo" dict "Value" .Keyword "Placeholder" (ctx.Locale.Tr "search.pull_kind") "Tooltip" (ctx.Locale.Tr "explore.go_to")}}

tests/integration/issue_test.go

@@ -1438,6 +1438,47 @@ func TestIssueCount(t *testing.T) {
 	assert.Contains(t, allCount, "2\u00a0All")
 }
 
+func TestIssueDefaultValues(t *testing.T) {
+	defer tests.PrepareTestEnv(t)()
+
+	links := []string{"/user2/repo1/issues", "/user2/repo1/pulls"}
+	values := []url.Values{
+		{
+			"type": {"created_by"},
+		},
+		{
+			"poster": {"1"},
+		},
+		{
+			"sort": {"latest"},
+		},
+		{
+			"type":   {"all"},
+			"sort":   {"latest"},
+			"poster": {"1"},
+		},
+		{
+			"type":   {"assigned"},
+			"sort":   {"oldest"},
+			"poster": {"1"},
+		},
+	}
+
+	for _, link := range links {
+		t.Run(link[13:], func(t *testing.T) {
+			for _, value := range values {
+				req := NewRequestf(t, "GET", "%s?%s", link, value.Encode())
+				resp := MakeRequest(t, req, http.StatusOK)
+
+				htmlDoc := NewHTMLParser(t, resp.Body)
+				for name := range value {
+					assert.Equal(t, value.Get(name), htmlDoc.GetInputValueByName(name))
+				}
+			}
+		})
+	}
+}
+
 func TestIssuePostersSearch(t *testing.T) {
 	defer tests.PrepareTestEnv(t)()