Skip to content

Commit bc99bf5

Browse files
earl-warrenEarl Warren
authored andcommitted
fix: do not set GOPROXY=direct in Dockerfile* (go-gitea#7707)
The default should be https://proxy.golang.org,direct otherwise someone trying to build the container image from sources will run into throttling limits imposed by code.forgejo.org (making more tha 10 request per second). Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7707 Reviewed-by: Gusted <[email protected]> Reviewed-by: Michael Kriese <[email protected]> Reviewed-by: Lucas <[email protected]> Co-authored-by: Earl Warren <[email protected]> Co-committed-by: Earl Warren <[email protected]>
1 parent b25091f commit bc99bf5

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ FROM --platform=$BUILDPLATFORM data.forgejo.org/oci/xx AS xx
33
FROM --platform=$BUILDPLATFORM data.forgejo.org/oci/golang:1.24-alpine3.21 AS build-env
44

55
ARG GOPROXY
6-
ENV GOPROXY=${GOPROXY:-direct}
6+
ENV GOPROXY=${GOPROXY:-https://proxy.golang.org,direct}
77

88
ARG RELEASE_VERSION
99
ARG TAGS="sqlite sqlite_unlock_notify"

Dockerfile.rootless

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ FROM --platform=$BUILDPLATFORM data.forgejo.org/oci/xx AS xx
33
FROM --platform=$BUILDPLATFORM data.forgejo.org/oci/golang:1.24-alpine3.21 AS build-env
44

55
ARG GOPROXY
6-
ENV GOPROXY=${GOPROXY:-direct}
6+
ENV GOPROXY=${GOPROXY:-https://proxy.golang.org,direct}
77

88
ARG RELEASE_VERSION
99
ARG TAGS="sqlite sqlite_unlock_notify"

0 commit comments

Comments
 (0)