Skip to content

Commit 086a8f9

Browse files
mfenniakearl-warren
authored andcommitted
test: remove internal timeout in TestRunnerCacheConfiguration (#906)
Performance has been in the range of 2.5 - 3 minutes for the "runner integration tests" step, causing this arbitrary timeout to be hit. The timeout was useful for early test development when nothing was running successfully, but meaningful now. Fixes #905. <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - other - [PR](https://code.forgejo.org/forgejo/runner/pulls/906): <!--number 906 --><!--line 0 --><!--description dGVzdDogcmVtb3ZlIGludGVybmFsIHRpbWVvdXQgaW4gVGVzdFJ1bm5lckNhY2hlQ29uZmlndXJhdGlvbg==-->test: remove internal timeout in TestRunnerCacheConfiguration<!--description--> <!--end release-notes-assistant--> Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/906 Reviewed-by: earl-warren <[email protected]> Co-authored-by: Mathieu Fenniak <[email protected]> Co-committed-by: Mathieu Fenniak <[email protected]>
1 parent fac8be3 commit 086a8f9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

internal/app/run/runner_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ func TestRunnerCacheConfiguration(t *testing.T) {
171171
// Must set up cache for our test
172172
require.NotNil(t, runner.cacheProxy)
173173

174-
ctx, cancel := context.WithTimeout(context.Background(), 3*time.Minute)
174+
ctx, cancel := context.WithCancel(t.Context())
175175
defer cancel()
176176

177177
// Run a given workflow w/ event...

0 commit comments

Comments
 (0)