Skip to content

Commit 93f84db

Browse files
shgewGusted
authored andcommitted
fix(ui): display verified icon for default gpg key (#6803)
I noticed that the icon next to the GPG key reference appears to be incorrect for commits signed by the default GPG key. Looking into the commit history of the template file, I noticed that Forgejo-signed commits originally had a distinct icon: gitea-unlock-cog --> octicon-shield-lock --> octicon-unverified (current) Since octicon-unverified is also used when a commit cannot be verified (.Verification.Warning), I find it misleading for successfully signed commits. This PR changes the icon to the verified variant for better clarity. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6803 Reviewed-by: Gusted <[email protected]> Reviewed-by: Otto <[email protected]> Co-authored-by: shgew <[email protected]> Co-committed-by: shgew <[email protected]>
1 parent c48f857 commit 93f84db

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

templates/repo/commit_page.tmpl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -217,8 +217,8 @@
217217
</div>
218218
<div class="tw-flex tw-items-center">
219219
{{if .Verification.Verified}}
220+
{{svg "octicon-verified" 16 "tw-mr-2"}}
220221
{{if ne .Verification.SigningUser.ID 0}}
221-
{{svg "octicon-verified" 16 "tw-mr-2"}}
222222
{{if .Verification.SigningSSHKey}}
223223
<span class="ui text tw-mr-2">{{ctx.Locale.Tr "repo.commits.ssh_key_fingerprint"}}:</span>
224224
{{.Verification.SigningSSHKey.Fingerprint}}
@@ -227,7 +227,6 @@
227227
{{.Verification.SigningKey.PaddedKeyID}}
228228
{{end}}
229229
{{else}}
230-
{{svg "octicon-unverified" 16 "tw-mr-2"}}
231230
{{if .Verification.SigningSSHKey}}
232231
<span class="ui text tw-mr-2" data-tooltip-content="{{ctx.Locale.Tr "gpg.default_key"}}">{{ctx.Locale.Tr "repo.commits.ssh_key_fingerprint"}}:</span>
233232
{{.Verification.SigningSSHKey.Fingerprint}}

0 commit comments

Comments
 (0)