Add MODULE.bazel.lock update to pre-commit

bzlmod typically updates MODULE.bazel.lock on an as-needed basis, as you
refer to targets that trigger the need for a dependency listed in the
MODULE.bazel.

If you make a dependency change, but only run a subset of tests, you may
end up with a lock file that is different than the one that would result
from a full presubmit. Leading to a CI failure, since there's a
non-empty git diff now.

This change adds this check to pre-commit, so you can easily get
lockfiles up to date locally, and so that in cases where they are out of
date, CI will fail faster.

Change-Id: I72ccf4c520377c8275961dee5cf385936a6a6964

Author: jblebrun

.pre-commit-config.yaml

@@ -1,6 +1,7 @@
 exclude: third_party/
 
-# The hooks here are using tools that we have pre-installed using flake.nix.
+# The hooks here are using tools that we have pre-installed using flake.nix, or
+# they are scripts in our scripts/ directory.
 repos:
   - repo: local
     hooks:
@@ -9,51 +10,67 @@ repos:
         entry: rustfmt
         language: system
         types: [rust]
+
       - id: buildifier
         name: buildifier (Bazel BUILD and .bzl files)
         entry: buildifier
         language: system
         types: [bazel]
+
+      - id: bzllock
+        name: Make sure MODULE.bazel.lock files are fully up to date
+        entry: ./scripts/bazel_mod_deps
+        language: system
+        files: MODULE.bazel$
+
       - id: clang-format
         name: clang-format (C/C++, Java, Proto)
         entry: clang-format -i
         language: system
         types_or: [c, c++, proto, java]
+
       - id: prettier
         name: prettier (YAML, HTML, JS, TS, CSS, SCSS)
         entry: prettier --write
         language: system
         types_or: [yaml, html, javascript, ts, css, scss]
+
       - id: hadolint
         name: hadolint (Dockerfiles)
         entry: hadolint
         language: system
         types: [dockerfile]
+
       - id: ktfmt
         name: ktfmt (Kotlin)
         entry: ktfmt -F --google-style
         language: system
         types: [kotlin]
+
       - id: markdownlint (Markdown files)
         name: apply markdownlint for markdown files
         entry: markdownlint --fix
         types: [markdown]
         language: system
-      - id: shellcheck (Shell Script Files)
-        name: apply shellcheck for shell scripts
+
+      - id: shellcheck
+        name: shellcheck (shell script files)
         entry: shellcheck --external-sources --exclude=SC2155
         language: system
         types: [shell]
+
       - id: nix
         name: nixfmt (Nix)
         entry: nix fmt
         language: system
         types: [nix]
+
       - id: terraform fmt
         name: terraform fmt
         entry: terraform fmt --write=true
         language: system
         types: [terraform]
+
       - id: badtodo
         name: Bad TODOs
         language: system
@@ -77,11 +94,13 @@ repos:
             markdown,
             shell,
           ]
+
       - id: bazellic
         name: Add notice license to all bazel packages
         language: system
         entry: ./scripts/add_bazel_license
         files: BUILD
+
       - id: sourcelic
         name: Add Apache License to source files
         language: system
@@ -95,3 +114,4 @@ repos:
         name: id
         language: system
         entry: echo
+        files: MODULE.bazel$

scripts/bazel_mod_deps

@@ -0,0 +1,11 @@
+#!/usr/bin/env bash
+set -o errexit
+set -o nounset
+set -o pipefail
+
+# Run bazel mod deps on each provided MODULE.bazel file to ensure that the lock file is fully up to date.
+for file in "$@"; do
+    pushd "$(dirname "$file")"
+    bazel mod deps
+    popd
+done