Skip to content

Commit c7b6aea

Browse files
authored
Merge pull request #998 from project-primera/feat/pre-sort-all-user
ユーザー一覧をプレソートするように
2 parents 023166f + bbb740a commit c7b6aea

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

OngekiScoreLog/app/UserStatus.php

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,17 @@ function getRecentUserData($id, $exclude_private = true)
1515
->from($this->table)->where('user_id', $id)->orderBy('id', 'desc')->limit(1);
1616

1717
$me = \Auth::user();
18-
# プライベートユーザを除外(自分自身以外) 管理者権限がある場合は除外しない
19-
if ($exclude_private && ($me === null || $me->role !== 7)) {
20-
if ($me === null || $id != $me->id) {
21-
$sql = $sql
22-
->join('users', "$this->table.user_id", '=', 'users.id')
23-
->where('users.private', 0);
24-
}
18+
19+
// 管理者には見せる
20+
if ($me !== null && $me->role === 7) {
21+
$exclude_private = false;
22+
}
23+
24+
# プライベートユーザを除外(自分自身以外)
25+
if ($exclude_private && ($me === null || $id != $me->id)) {
26+
$sql = $sql
27+
->join('users', "$this->table.user_id", '=', 'users.id')
28+
->where('users.private', 0);
2529
}
2630

2731
return $sql->select("$this->table.*")->get();
@@ -50,9 +54,9 @@ function getRecentAllUserData($exclude_private = true)
5054
->join('users', 't1.user_id', '=', 'users.id')
5155
->where('users.private', 0);
5256

53-
$sql = $sql_all_users->select('t1.*')->get();
57+
$sql = $sql_all_users->select('t1.*')->orderBy('t1.created_at', 'desc')->get();
5458
} else {
55-
$sql = DB::select('SELECT * FROM user_status AS t1 WHERE created_at = (SELECT MAX(created_at) FROM user_status AS t2 WHERE t1.user_id = t2.user_id)');
59+
$sql = DB::select('SELECT * FROM user_status AS t1 WHERE created_at = (SELECT MAX(created_at) FROM user_status AS t2 WHERE t1.user_id = t2.user_id) ORDER BY t1.created_at DESC');
5660
}
5761

5862
$users = [];

OngekiScoreLog/resources/assets/js/sortAllUserTable.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ var options = {
22
valueNames: ['sort_id', 'sort_name', 'sort_trophy', 'sort_lv', 'sort_rating', 'sort_max', 'sort_bp', 'sort_update']
33
};
44
var sortTable = new List('sort_table', options);
5-
sortTable.sort('sort_update', {order: "desc"});
5+
// sortTable.sort('sort_update', {order: "desc"});

0 commit comments

Comments
 (0)