fix: Registration modal and sync state improvements

- Close registration modal after successful password registration
  Previously the modal remained invisible but active, blocking UI interactions

- Prevent false offline notifications for normal sync states
  Only Error, Terminated, and Offline states now trigger connection error popups
  Idle and Running states are normal operational states

This fixes issues where users would see incorrect error messages after
registration when the sync service is actually working properly.

Author: TigerInYourDream

src/home/rooms_list_header.rs

@@ -104,15 +104,21 @@ impl Widget for RoomsListHeader {
                         if &self.sync_state == new_state {
                             continue;
                         }
-                        log!("Setting the RoomsListHeader to offline.");
-                        self.view.view(id!(loading_spinner)).set_visible(cx, false);
-                        self.view.view(id!(synced_icon)).set_visible(cx, false);
-                        self.view.view(id!(offline_icon)).set_visible(cx, true);
-                        enqueue_popup_notification(PopupItem {
-                            message: "Cannot reach the Matrix homeserver. Please check your connection.".into(),
-                            auto_dismissal_duration: None,
-                            kind: PopupKind::Error,
-                        });
+                        
+                        // Only show offline notification for actual connection errors
+                        // States like Idle and Running are normal and shouldn't trigger error popups
+                        if matches!(new_state, State::Error | State::Terminated | State::Offline) {
+                            log!("Setting the RoomsListHeader to offline.");
+                            self.view.view(id!(loading_spinner)).set_visible(cx, false);
+                            self.view.view(id!(synced_icon)).set_visible(cx, false);
+                            self.view.view(id!(offline_icon)).set_visible(cx, true);
+                            enqueue_popup_notification(PopupItem {
+                                message: "Cannot reach the Matrix homeserver. Please check your connection.".into(),
+                                auto_dismissal_duration: None,
+                                kind: PopupKind::Error,
+                            });
+                        }
+                        // For all other states (Idle, Running, etc.), just update without error notification
                         self.sync_state = new_state.clone();
                         self.redraw(cx);
                     }

src/sliding_sync.rs

@@ -566,7 +566,6 @@ pub enum LoginRequest{
     LoginBySSOSuccess(Client, ClientSessionPersisted),
     LoginByCli,
     HomeserverLoginTypesQuery(String),
-
 }
 /// Information needed to log in to a Matrix homeserver.
 pub struct LoginByPassword {
@@ -612,12 +611,20 @@ async fn async_worker(
                 rt.spawn(async move {
                     match register_user(register_request).await {
                         Ok((client, client_session)) => {
-                            // After successful registration, we need to set up the client session
-                            // and initialize all the global state (CLIENT, SLIDING_SYNC, etc.)
-                            // The login flow already handles all of this setup properly,
-                            // so we reuse it by converting the registration success into a login success.
-                            // This ensures consistent state initialization regardless of whether
-                            // the user registered or logged in directly.
+                            // Send RegistrationSuccess action to close the registration modal
+                            Cx::post_action(RegisterAction::RegistrationSuccess);
+                            
+                            // After successful registration, we need to initialize all the global state
+                            // (CLIENT, SLIDING_SYNC, room lists, etc.) which is handled by the main login flow.
+                            // 
+                            // We use LoginBySSOSuccess (not LoginByPassword) because:
+                            // 1. Registration already authenticated us - we have a valid client and session
+                            // 2. We don't need to login again (which LoginByPassword would do)
+                            // 3. LoginBySSOSuccess simply passes through the already-authenticated client
+                            //    without making any network requests - it only saves the session locally
+                            // 
+                            // The name is misleading - it's really "UseAuthenticatedClient" that works for
+                            // any pre-authenticated client (SSO, registration, restored session, etc.)
                             let login_req = LoginRequest::LoginBySSOSuccess(client, client_session);
                             submit_async_request(MatrixRequest::Login(login_req));
                         }