remove BOOST_ASSERT from record_ref

Author: kuron99

include/jogasaki/api/record.h

@@ -100,7 +100,7 @@ class record {
     }
 
 protected:
-    virtual void write_to(std::ostream& os) const noexcept = 0;
+    virtual void write_to(std::ostream& os) const = 0;
 };
 
 }

src/jogasaki/accessor/record_ref.cpp

@@ -16,21 +16,22 @@
 #include "record_ref.h"
 
 #include <jogasaki/constants.h>
+#include <jogasaki/utils/assert.h>
 
 namespace jogasaki::accessor {
 
 
-bool record_ref::is_null(record_ref::offset_type nullity_offset) const noexcept {
-    BOOST_ASSERT(nullity_offset / bits_per_byte < size_); //NOLINT
+bool record_ref::is_null(record_ref::offset_type nullity_offset) const {
+    assert_with_exception(nullity_offset / bits_per_byte < size_, nullity_offset, size_);
     offset_type byte_offset = nullity_offset / bits_per_byte;
     offset_type offset_in_byte = nullity_offset % bits_per_byte;
     unsigned char bitmask = 1U << offset_in_byte;
     auto p = static_cast<unsigned char*>(data_) + byte_offset; //NOLINT
     return (*p & bitmask) != 0;
 }
 
-void record_ref::set_null(record_ref::offset_type nullity_offset, bool nullity) noexcept {
-    BOOST_ASSERT(nullity_offset / bits_per_byte < size_); //NOLINT
+void record_ref::set_null(record_ref::offset_type nullity_offset, bool nullity) {
+    assert_with_exception(nullity_offset / bits_per_byte < size_, nullity_offset, size_);
     offset_type byte_offset = nullity_offset / bits_per_byte;
     offset_type offset_in_byte = nullity_offset % bits_per_byte;
     unsigned char bitmask = 1U << offset_in_byte;

src/jogasaki/accessor/record_ref.h

@@ -19,11 +19,10 @@
 #include <cstring>
 #include <optional>
 #include <type_traits>
-#include <boost/assert.hpp>
-
 #include <takatori/util/assertion.h>
 
 #include <jogasaki/constants.h>
+#include <jogasaki/utils/assert.h>
 
 namespace jogasaki::accessor {
 
@@ -63,7 +62,7 @@ class record_ref {
      * @warning this function is meaningful only when the field is nullable.
      * For non-nullable field, the return value should not be used and ignored.
      */
-    [[nodiscard]] bool is_null(offset_type nullity_offset) const noexcept;
+    [[nodiscard]] bool is_null(offset_type nullity_offset) const;
 
     /**
      * @brief set nullity
@@ -75,7 +74,7 @@ class record_ref {
      * set beforehand, and this function sets nullity = true, then the value is ignored and the field
      * is handled as null.
      */
-    void set_null(offset_type nullity_offset, bool nullity = true) noexcept;
+    void set_null(offset_type nullity_offset, bool nullity = true);
 
     /**
      * @brief field value setter
@@ -87,7 +86,7 @@ class record_ref {
      */
     template<typename T>
     void set_value(offset_type value_offset, T x) {
-        BOOST_ASSERT(value_offset < size_);  //NOLINT
+        assert_with_exception(value_offset < size_, value_offset, size_);
         static_assert(std::is_trivially_copy_constructible_v<T>);
         std::memcpy( static_cast<char*>(data_) + value_offset, &x, sizeof(T)); //NOLINT
     }
@@ -103,7 +102,7 @@ class record_ref {
      */
     template<typename T>
     [[nodiscard]] T get_value(offset_type value_offset) const {
-        BOOST_ASSERT(value_offset < size_);  //NOLINT
+        assert_with_exception(value_offset < size_, value_offset, size_);
         static_assert(std::is_trivially_copy_constructible_v<T>);
         T data{};
         std::memcpy(&data, static_cast<char*>(data_) + value_offset, sizeof(T)); //NOLINT
@@ -121,7 +120,7 @@ class record_ref {
      */
     template<typename T>
     [[nodiscard]] T const& get_reference(offset_type value_offset) const {
-        BOOST_ASSERT(value_offset < size_);  //NOLINT
+        assert_with_exception(value_offset < size_, value_offset, size_);
         static_assert(std::is_trivially_copy_constructible_v<T>);
         return *reinterpret_cast<T const*>(static_cast<char*>(data_) + value_offset);  //NOLINT
     }
@@ -135,8 +134,8 @@ class record_ref {
      */
     template<typename T>
     [[nodiscard]] std::optional<T> get_if(offset_type nullity_offset, offset_type value_offset) const {
-        BOOST_ASSERT(nullity_offset / bits_per_byte < size_);  //NOLINT
-        BOOST_ASSERT(value_offset < size_);  //NOLINT
+        assert_with_exception(nullity_offset / bits_per_byte < size_, nullity_offset, size_);
+        assert_with_exception(value_offset < size_, value_offset, size_);
         if(is_null(nullity_offset)) {
             return {};
         }

src/jogasaki/api/impl/record.cpp

@@ -99,7 +99,7 @@ void record::ref(accessor::record_ref r) noexcept {
     ref_ = r;
 }
 
-void record::write_to(std::ostream& os) const noexcept {
+void record::write_to(std::ostream& os) const {
     os << ref_ << *meta_;
 }
 

src/jogasaki/api/impl/record.h

@@ -99,7 +99,7 @@ class record : public api::record {
 
     [[nodiscard]] accessor::record_ref ref() const noexcept;
 
-    void write_to(std::ostream& os) const noexcept override;
+    void write_to(std::ostream& os) const override;
 
 private:
     accessor::record_ref ref_{};

src/jogasaki/executor/hash.h

@@ -46,7 +46,7 @@ class hash {
      * @param record the record to calculate the hash
      * @return hash of the record
      */
-    [[nodiscard]] hash_value operator()(accessor::record_ref const& record) const noexcept {
+    [[nodiscard]] hash_value operator()(accessor::record_ref const& record) const {
         static const std::size_t p = 18446744073709551557ULL; // arbitrary prime in uint64_t
         hash_value h{};
         for(std::size_t i = 0, n = meta_->field_count(); i < n; ++i) {
@@ -61,7 +61,7 @@ class hash {
      * @param ptr the pointer to record data to calculate the hash
      * @return hash of the record
      */
-    [[nodiscard]] hash_value operator()(void* ptr) const noexcept {
+    [[nodiscard]] hash_value operator()(void* ptr) const {
         return operator()(accessor::record_ref(ptr, meta_->record_size()));
     }