Skip to content

Commit 1193f7b

Browse files
Migrate all libraries to version catalog and bump libraries (#403)
1 parent 64d2e95 commit 1193f7b

File tree

18 files changed

+100
-102
lines changed

18 files changed

+100
-102
lines changed

android/app-newm/build.gradle.kts

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ apply(from = "../../gradle_include/circuit.gradle")
88
apply(from = "../../gradle_include/flipper.gradle")
99

1010
plugins {
11-
id("com.android.application")
12-
id("com.google.gms.google-services")
13-
id("kotlin-parcelize")
14-
kotlin("android")
15-
kotlin("kapt")
16-
id("io.sentry.android.gradle") version "5.12.1"
11+
alias(libs.plugins.androidApplication)
12+
alias(libs.plugins.googleServices)
13+
alias(libs.plugins.kotlin.plugin.parcelize)
14+
alias(libs.plugins.kotlinAndroid)
15+
alias(libs.plugins.kotlinKapt)
16+
alias(libs.plugins.sentry)
1717
alias(libs.plugins.compose.multiplatform)
1818
}
1919

@@ -101,6 +101,8 @@ dependencies {
101101
implementation(libs.androidx.constraintlayout)
102102
implementation(libs.firebase.analytics)
103103
implementation(libs.androidx.lifecycle.runtime.ktx)
104+
implementation(libs.kotlinx.collections.immutable)
105+
implementation(libs.circuit.retained)
104106
implementation(compose.material)
105107
implementation(libs.androidx.media3.datasource)
106108
implementation(libs.androidx.media3.exoplayer)

android/app-newm/src/main/java/io/newm/HomeActivity.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import androidx.compose.runtime.getValue
1111
import com.slack.circuit.foundation.Circuit
1212
import com.slack.circuit.foundation.CircuitCompositionLocals
1313
import com.slack.circuit.retained.LocalRetainedStateRegistry
14-
import com.slack.circuit.retained.continuityRetainedStateRegistry
14+
import com.slack.circuit.retained.lifecycleRetainedStateRegistry
1515
import com.slack.circuit.runtime.presenter.Presenter
1616
import com.slack.circuit.runtime.ui.Ui
1717
import io.newm.core.theme.NewmTheme
@@ -296,7 +296,7 @@ class HomeActivity : ComponentActivity() {
296296
fun CircuitDependencies(content: @Composable () -> Unit) {
297297
CircuitCompositionLocals(circuit) {
298298
CompositionLocalProvider(
299-
LocalRetainedStateRegistry provides continuityRetainedStateRegistry(),
299+
LocalRetainedStateRegistry provides lifecycleRetainedStateRegistry(),
300300
LocalIsBottomBarVisible provides isBottomBarVisible(),
301301
) {
302302
content()

android/app-newm/src/main/java/io/newm/LoginActivity.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import com.slack.circuit.foundation.CircuitCompositionLocals
2323
import com.slack.circuit.foundation.NavigableCircuitContent
2424
import com.slack.circuit.foundation.rememberCircuitNavigator
2525
import com.slack.circuit.retained.LocalRetainedStateRegistry
26-
import com.slack.circuit.retained.continuityRetainedStateRegistry
26+
import com.slack.circuit.retained.lifecycleRetainedStateRegistry
2727
import com.slack.circuit.runtime.presenter.Presenter
2828
import com.slack.circuit.runtime.ui.Ui
2929
import io.newm.core.theme.NewmTheme
@@ -180,7 +180,7 @@ class LoginActivity : ComponentActivity() {
180180
fun CircuitDependencies(content: @Composable () -> Unit) {
181181
CircuitCompositionLocals(circuit) {
182182
CompositionLocalProvider(
183-
LocalRetainedStateRegistry provides continuityRetainedStateRegistry(),
183+
LocalRetainedStateRegistry provides lifecycleRetainedStateRegistry(),
184184
) {
185185
content()
186186
}

android/app-newm/src/main/java/io/newm/NewmNavigator.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import io.newm.shared.NewmAppLogger
1010
import io.newm.shared.commonPublic.analytics.NewmAppEventLogger
1111
import io.newm.sharedfeatures.screens.HomeScreen
1212
import kotlinx.collections.immutable.ImmutableList
13+
import kotlinx.collections.immutable.toImmutableList
1314

1415
@Composable
1516
fun rememberNewmNavigator(
@@ -54,19 +55,18 @@ private class NewmNavigator(
5455
}
5556

5657
override fun pop(result: PopResult?): Screen? {
57-
val screen = circuitNavigator.pop()
58+
val screen = circuitNavigator.pop(result)
5859
logger.debug(tag = "NewmNavigator", message = "Popping screen: $screen")
5960
return screen
6061
}
6162

6263
override fun resetRoot(
6364
newRoot: Screen,
64-
saveState: Boolean,
65-
restoreState: Boolean,
65+
options: Navigator.StateOptions,
6666
): ImmutableList<Screen> {
6767
logger.debug(tag = "NewmNavigator", message = "Resetting root to $newRoot")
6868
logPageViewEvent(newRoot)
69-
return circuitNavigator.resetRoot(newRoot)
69+
return circuitNavigator.resetRoot(newRoot, options).toImmutableList()
7070
}
7171

7272
private fun logPageViewEvent(screen: Screen) {

android/core/android/implementations/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
plugins {
2-
id("com.android.library")
3-
kotlin("android")
2+
alias(libs.plugins.androidLibrary)
3+
alias(libs.plugins.kotlinAndroid)
44
}
55

66
android {

android/core/resources/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
plugins {
2-
id("com.android.library")
3-
kotlin("android")
2+
alias(libs.plugins.androidLibrary)
3+
alias(libs.plugins.kotlinAndroid)
44
}
55

66
android {

android/core/test-utils/build.gradle.kts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
plugins {
2-
id("com.android.library")
3-
kotlin("android")
2+
alias(libs.plugins.androidLibrary)
3+
alias(libs.plugins.kotlinAndroid)
44
}
55

66
apply(from = "../../../gradle_include/circuit.gradle")
@@ -21,10 +21,10 @@ android {
2121
sourceCompatibility = JavaVersion.VERSION_11
2222
targetCompatibility = JavaVersion.VERSION_11
2323
}
24-
25-
kotlinOptions { jvmTarget = "11" }
2624
}
2725

26+
kotlin { compilerOptions { jvmTarget.set(org.jetbrains.kotlin.gradle.dsl.JvmTarget.JVM_11) } }
27+
2828
dependencies {
2929
implementation(libs.paparazzi)
3030
implementation(project(Modules.CORE_THEME))

android/core/theme/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import org.jetbrains.kotlin.gradle.ExperimentalWasmDsl
22
import org.jetbrains.kotlin.gradle.dsl.JvmTarget
33

44
plugins {
5-
id("com.android.library")
5+
alias(libs.plugins.androidLibrary)
66
alias(libs.plugins.kotlinMultiplatform)
77
alias(libs.plugins.compose.multiplatform)
88
}

android/core/ui-utils/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import org.jetbrains.kotlin.gradle.ExperimentalWasmDsl
22
import org.jetbrains.kotlin.gradle.dsl.JvmTarget
33

44
plugins {
5-
id("com.android.library")
5+
alias(libs.plugins.androidLibrary)
66
alias(libs.plugins.kotlinMultiplatform)
77
alias(libs.plugins.compose.multiplatform)
88
alias(libs.plugins.compose.compiler)

android/features/barcode-scanner/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
plugins {
2-
id("com.android.library")
3-
id("org.jetbrains.kotlin.android")
2+
alias(libs.plugins.androidLibrary)
3+
alias(libs.plugins.kotlinAndroid)
44
alias(libs.plugins.compose.multiplatform)
55
}
66

0 commit comments

Comments
 (0)