Skip to content

Commit e71b1c6

Browse files
wlaraWalter Lara
andauthored
Attempt to fix Google sign-in user switch (#330)
Co-authored-by: Walter Lara <walter.lara@nike.com>
1 parent b60c355 commit e71b1c6

File tree

2 files changed

+14
-13
lines changed

2 files changed

+14
-13
lines changed

android/app-newm/src/main/java/io/newm/Logout.kt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
package io.newm
44

55
import android.content.Context
6+
import com.google.android.gms.auth.api.signin.GoogleSignInClient
67
import com.jakewharton.processphoenix.ProcessPhoenix
78
import io.newm.shared.NewmAppLogger
89
import io.newm.shared.public.usecases.LoginUseCase
@@ -17,13 +18,15 @@ class Logout(
1718
private val userSessionUseCase: UserSessionUseCase,
1819
private val restartApp: RestartApp,
1920
private val scope: CoroutineScope,
20-
private val logger: NewmAppLogger
21+
private val logger: NewmAppLogger,
22+
private val googleSignInClient: GoogleSignInClient
2123
) {
2224

2325
fun signOutUser() {
2426
scope.launch {
2527
try {
2628
loginUseCase.logout()
29+
googleSignInClient.signOut()
2730
logger.info("Logout", "Logout successful")
2831
restartApp.run()
2932
} catch (e: Exception) {

android/app-newm/src/main/java/io/newm/di/android/Dependencies.kt

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -41,20 +41,18 @@ val viewModule = module {
4141
get()
4242
, get())
4343
}
44-
single<GoogleSignInLauncher> {
44+
single {
4545
val sharedBuildConfig = get<NewmSharedBuildConfig>()
46-
47-
GoogleSignInLauncherImpl(
48-
GoogleSignIn.getClient(
49-
androidContext(),
50-
GoogleSignInOptions.Builder(GoogleSignInOptions.DEFAULT_SIGN_IN)
51-
.requestIdToken(sharedBuildConfig.googleAuthClientId)
52-
.requestScopes(Scope(Scopes.EMAIL), Scope(Scopes.PROFILE))
53-
.requestEmail()
54-
.build()
55-
)
46+
GoogleSignIn.getClient(
47+
androidContext(),
48+
GoogleSignInOptions.Builder(GoogleSignInOptions.DEFAULT_SIGN_IN)
49+
.requestIdToken(sharedBuildConfig.googleAuthClientId)
50+
.requestScopes(Scope(Scopes.EMAIL), Scope(Scopes.PROFILE))
51+
.requestEmail()
52+
.build()
5653
)
5754
}
55+
single<GoogleSignInLauncher> { GoogleSignInLauncherImpl(get()) }
5856
factory { params ->
5957
WelcomeScreenPresenter(
6058
navigator = params.get(),
@@ -109,6 +107,6 @@ val viewModule = module {
109107
}
110108

111109
val androidModules = module {
112-
single { Logout(get(), get(), get(), get(), get()) }
110+
single { Logout(get(), get(), get(), get(), get(), get()) }
113111
single { RestartApp(get()) }
114112
}

0 commit comments

Comments
 (0)