Skip to content

Commit aa81135

Browse files
authored
Align facets for creators, subjects, places with terms used elsewhere (#1489)
1 parent 540e640 commit aa81135

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

lib/generators/arclight/templates/catalog_controller.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -139,13 +139,13 @@ class CatalogController < ApplicationController
139139
# (note: It is case sensitive when searching values)
140140

141141
config.add_facet_field 'collection', field: 'collection_ssim', limit: 10
142-
config.add_facet_field 'creator', field: 'creator_ssim', limit: 10
142+
config.add_facet_field 'creators', field: 'creator_ssim', limit: 10
143143
config.add_facet_field 'date_range', field: 'date_range_isim', range: true
144144
config.add_facet_field 'level', field: 'level_ssim', limit: 10
145145
config.add_facet_field 'names', field: 'names_ssim', limit: 10
146146
config.add_facet_field 'repository', field: 'repository_ssim', limit: 10
147-
config.add_facet_field 'place', field: 'geogname_ssim', limit: 10
148-
config.add_facet_field 'subject', field: 'access_subjects_ssim', limit: 10
147+
config.add_facet_field 'places', field: 'geogname_ssim', limit: 10
148+
config.add_facet_field 'access_subjects', field: 'access_subjects_ssim', limit: 10
149149

150150
# Have BL send all facet field names to Solr, which has been the default
151151
# previously. Simply remove these lines if you'd rather use Solr request

spec/features/search_results_spec.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@
8787
expect(page).to have_css('li .facet-label', text: 'Other', visible: :hidden) # "otherlevel" but missing alt val
8888
end
8989

90-
within('.blacklight-creator') do
90+
within('.blacklight-creators') do
9191
expect(page).to have_css('h3 button', text: 'Creator')
9292
expect(page).to have_css('li .facet-label', text: 'Alpha Omega Alpha', visible: :hidden)
9393
expect(page).to have_css('li .facet-label', text: 'Stanford University', visible: :hidden)
@@ -104,14 +104,14 @@
104104
expect(page).to have_css('li .facet-label', text: 'National Library of Medicine. History of Medicine Division', visible: :hidden)
105105
end
106106

107-
within('.blacklight-place') do
108-
expect(page).to have_css('h3 button', text: 'Place')
107+
within('.blacklight-places') do
108+
expect(page).to have_css('h3 button', text: 'Places')
109109
expect(page).to have_css('li .facet-label', text: 'Mindanao Island (Philippines)', visible: :hidden)
110110
expect(page).to have_css('li .facet-label', text: 'Yosemite National Park (Calif.)', visible: :hidden)
111111
end
112112

113-
within('.blacklight-subject') do
114-
expect(page).to have_css('h3 button', text: 'Subject')
113+
within('.blacklight-access_subjects') do
114+
expect(page).to have_css('h3 button', text: 'Subjects')
115115
expect(page).to have_css('li .facet-label', text: 'Slides.', visible: :hidden)
116116
expect(page).to have_css('li .facet-label', text: 'Fraternizing', visible: :hidden)
117117
end

0 commit comments

Comments
 (0)