Get linting green on release-8.x branch (#3574)

Author: maxkadel

app/controllers/concerns/blacklight/search_context.rb

@@ -40,7 +40,7 @@ def page_links
         @page_link_data[:prev] = page_links_document_path(documents.first, index)
         @page_link_data[:next] = page_links_document_path(documents.last, index + 2)
       end
-      if response&.total && response.total.positive?
+      if response&.total&.positive?
         @page_link_data[:counterRaw] = counter_param
         @page_link_data[:counterDelimited] = helpers.number_with_delimiter(counter_param.to_i)
         @page_link_data[:totalRaw] = response.total

lib/blacklight/configuration/field.rb

@@ -33,6 +33,7 @@ def validate!
       raise ArgumentError, "Must supply a field name" if self.field.nil?
     end
 
+    # rubocop:disable Style/RedundantParentheses
     def display_label(context = nil, **options)
       field_label(
         (:"blacklight.search.fields.#{context}.#{key}" if context),
@@ -42,6 +43,7 @@ def display_label(context = nil, **options)
         **options
       )
     end
+    # rubocop:enable Style/RedundantParentheses
 
     def default_label
       if self.key.respond_to?(:titleize)