chore(golangci-lint): upgrading to v1.61.0

Author: prometherion

.golangci.yml

@@ -1,6 +1,4 @@
 linters-settings:
-  govet:
-    check-shadowing: true
   gci:
     sections:
       - standard
@@ -22,23 +20,21 @@ linters:
     - ireturn
     - varnamelen
     - wrapcheck
-    - interfacer
-    - maligned
-    - golint
-    - scopelint
     - gomnd
-    - goerr113
-    - exhaustivestruct
     - lll
-    - ifshort
-    - deadcode
-    - structcheck
-    - varcheck
-    - nosnakecase
     - nonamedreturns
     - tparallel
     - nilerr
     - exhaustruct
     - depguard
-service:
-  golangci-lint-version: 1.55.x
+    # should be enabled
+    - revive
+    - err113
+    - mnd
+    - nilnil
+    - wsl
+    - perfsprint
+
+    # deprecated
+    - exportloopref
+    - execinquery

Makefile

@@ -264,7 +264,7 @@ mkcert: ## Download mkcert locally if necessary.
 	$(call go-install-tool,$(MKCERT),filippo.io/mkcert@$(MKCERT_VERSION))
 
 GOLANGCI_LINT = $(shell pwd)/bin/golangci-lint
-GOLANGCI_LINT_VERSION = v1.55.2
+GOLANGCI_LINT_VERSION = v1.61.0
 golangci-lint: ## Download golangci-lint locally if necessary.
 	$(call go-install-tool,$(GOLANGCI_LINT),github.com/golangci/golangci-lint/cmd/golangci-lint@$(GOLANGCI_LINT_VERSION))
 

internal/webserver/middleware/jwt.go

@@ -4,11 +4,11 @@
 package middleware
 
 import (
-	"fmt"
 	"net/http"
 	"strings"
 
 	"github.com/gorilla/mux"
+	goerrors "github.com/pkg/errors"
 	authenticationv1 "k8s.io/api/authentication/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/util/sets"
@@ -43,10 +43,10 @@ func CheckJWTMiddleware(client client.Writer) mux.MiddlewareFunc {
 				if statusErr := tr.Status.Error; len(statusErr) > 0 {
 					invalidatedToken.Insert(token)
 
-					errors.HandleUnauthorized(writer, fmt.Errorf(statusErr), "cannot authenticate the token due to error")
+					errors.HandleUnauthorized(writer, goerrors.New(statusErr), "cannot authenticate the token due to error")
 				}
 			case invalidatedToken.Has(token):
-				errors.HandleUnauthorized(writer, fmt.Errorf("token is invalid"), "cannot authenticate the token due to error")
+				errors.HandleUnauthorized(writer, goerrors.New("token is invalid"), "cannot authenticate the token due to error")
 			}
 
 			next.ServeHTTP(writer, request)

internal/webserver/middleware/metrics_test.go

@@ -50,7 +50,7 @@ func Test_MetricsMiddleware_RequestCount(t *testing.T) {
 
 		rw := httptest.NewRecorder()
 
-		for i := 0; i < test.requestCount; i++ {
+		for range test.requestCount {
 			req, err := newRequest("GET", test.path)
 			if err != nil {
 				t.Errorf("failed to create HTTP request object")

internal/webserver/webserver.go

@@ -315,7 +315,7 @@ func (n *kubeFilter) registerModules(ctx context.Context, root *mux.Router) {
 			case err != nil:
 				var t moderrors.Error
 				if errors.As(err, &t) {
-					writer.Header().Set("content-type", "application/json")
+					writer.Header().Set("Content-Type", "application/json")
 					b, _ := json.Marshal(t.Status())
 					_, _ = writer.Write(b)
 					panic(err.Error())