Fixed few static analysis issues<2>

1. Uncaught exception (UNCAUGHT_EXCEPT).
2. Unchecked return value (CHECKED_RETURN).
3. Assigning value MFX_ERR_INVALID_HANDLE to mfx_res here,
but that stored value is overwritten before it can be used.
4. Variable c2Handle going out of scope leaks the storage it points to.
5. Dereferencing null pointer outBuffer.

Tracked-On: OAM-112437
Signed-off-by: zhangyichix <yichix.zhang@intel.com>

Author: zhangyichix

c2_store/src/mfx_c2_service.cpp

@@ -106,11 +106,11 @@ int main(int /* argc */, char** /* argv */) {
         android::hardware::configureRpcThreadpool(8, true /* callerWillJoin */);
 
         RegisterC2Service();
+
+        android::hardware::joinRpcThreadpool();
+
     } catch(const std::exception& ex) {
         // ALOGE("hardware.intel.media.c2@1.0-service exception: %s", ex.what());
-        return 0;
     }
-
-    android::hardware::joinRpcThreadpool();
     return 0;
 }

c2_utils/src/mfx_gralloc1.cpp

@@ -280,7 +280,7 @@ buffer_handle_t MfxGralloc1Module::ImportBuffer(const buffer_handle_t rawHandle)
     buffer_handle_t *outBuffer = nullptr;
     int32_t gr1_res = (*m_grImportBufferFunc)(m_gralloc1_dev, rawHandle, outBuffer);
 
-    if (GRALLOC1_ERROR_NONE != gr1_res) {
+    if (GRALLOC1_ERROR_NONE != gr1_res || nullptr == outBuffer) {
         MFX_DEBUG_TRACE_I32(gr1_res);
         res = C2_BAD_STATE;
     }

c2_utils/src/mfx_va_frame_pool_allocator.cpp

@@ -25,6 +25,7 @@
 
 #include "mfx_c2_utils.h"
 #include "mfx_debug.h"
+#include "mfx_msdk_debug.h"
 
 #include <C2AllocatorGralloc.h>
 
@@ -155,6 +156,13 @@ mfxStatus MfxVaFramePoolAllocator::AllocFrames(mfxFrameAllocRequest *request,
             }
             MFX_DEBUG_TRACE_I32(response->NumFrameActual);
 
+            if (MFX_ERR_NONE != mfx_res) {
+                MFX_DEBUG_TRACE_MSG("Fatal error occurred while allocating memory");
+
+                MFX_DEBUG_TRACE__mfxStatus(mfx_res);
+                return mfx_res;
+            }
+
             if (response->NumFrameActual >= request->NumFrameMin) {
                 response->mids = mids.release();
                 m_pool = std::make_unique<MfxPool<C2GraphicBlock>>(); //release graphic buffer
@@ -172,6 +180,7 @@ mfxStatus MfxVaFramePoolAllocator::AllocFrames(mfxFrameAllocRequest *request,
         mfx_res = AllocFrames(request, response);
     }
 
+    MFX_DEBUG_TRACE__mfxStatus(mfx_res);
     return mfx_res;
 }
 

plugin_store/src/mfx_c2_buffer_queue.cpp

@@ -305,6 +305,8 @@ class MfxC2BufferQueueBlockPool::Impl
                 std::shared_ptr<C2GraphicAllocation> alloc;
                 c2_status_t err = mAllocator->priorGraphicAllocation(c2Handle, &alloc);
                 if (err != C2_OK) {
+                    native_handle_close(handle);
+                    native_handle_delete(handle);
                     return err;
                 }
                 std::shared_ptr<MfxC2BufferQueueBlockPoolData> poolData =
@@ -338,17 +340,20 @@ class MfxC2BufferQueueBlockPool::Impl
 
     ~Impl() {
         bool noInit = false;
-        for (int i = 0; i < NUM_BUFFER_SLOTS; ++i) {
-            if (!noInit && mProducer) {
-                Return<HStatus> transResult =
-                        mProducer->detachBuffer(static_cast<int32_t>(i));
-                noInit = !transResult.isOk() ||
-                         static_cast<HStatus>(transResult) == HStatus::NO_INIT;
+        try {
+                for (int i = 0; i < NUM_BUFFER_SLOTS; ++i) {
+                if (!noInit && mProducer) {
+                    Return<HStatus> transResult =
+                            mProducer->detachBuffer(static_cast<int32_t>(i));
+                    noInit = !transResult.isOk() ||
+                            static_cast<HStatus>(transResult) == HStatus::NO_INIT;
+                }
+                mBuffers[i].clear();
             }
-            mBuffers[i].clear();
+            gbuffer_.clear();
+        } catch(const std::exception& e) {
+            MFX_DEBUG_TRACE_STREAM("Got an exception: " << e.what());
         }
-
-        gbuffer_.clear();
     }
 
     c2_status_t handle(const C2Handle * c2_hdl, buffer_handle_t *hndl){
@@ -570,12 +575,16 @@ class MfxC2BufferQueueBlockPool::Impl
     void cancel(uint32_t generation, uint64_t igbp_id, int32_t igbp_slot) {
         bool cancelled = false;
         {
-        MFX_DEBUG_TRACE_FUNC;
-        std::scoped_lock<std::mutex> lock(mMutex);
-        if (generation == mGeneration && igbp_id == mProducerId && mProducer) {
-            (void)mProducer->cancelBuffer(igbp_slot, hidl_handle{}).isOk();
-            cancelled = true;
-        }
+            MFX_DEBUG_TRACE_FUNC;
+            try {
+                std::scoped_lock<std::mutex> lock(mMutex);
+                if (generation == mGeneration && igbp_id == mProducerId && mProducer) {
+                    (void)mProducer->cancelBuffer(igbp_slot, hidl_handle{}).isOk();
+                    cancelled = true;
+                }
+            } catch(const std::exception& e) {
+                MFX_DEBUG_TRACE_STREAM("Got an exception: " << e.what());
+            }
         }
     }
 
@@ -632,7 +641,7 @@ MfxC2BufferQueueBlockPoolData::~MfxC2BufferQueueBlockPoolData() {
             localPool->cancel(generation, bqId, bqSlot);
         }
     } else if (igbp && !owner.expired()) {
-        igbp->cancelBuffer(bqSlot, hidl_handle{}).isOk();
+        (void)igbp->cancelBuffer(bqSlot, hidl_handle{}).isOk();
     }
 }