Merge pull request #1523 from projectdiscovery/dev

bug fixes

Author: ehsandeep

.github/dependabot.yml

@@ -19,6 +19,10 @@ updates:
       - "Type: Maintenance"
     allow:
       - dependency-name: "github.com/projectdiscovery/*"
+    groups:
+      projectdiscovery:
+        patterns:
+          - "github.com/projectdiscovery/*"
 
   # Maintain dependencies for docker
   - package-ecosystem: "docker"
@@ -31,6 +35,10 @@ updates:
       include: "scope"
     labels:
       - "Type: Maintenance"
+    groups:
+      docker-dependencies:
+        patterns:
+          - "*"
 
   # Maintain dependencies for GitHub Actions
   - package-ecosystem: "github-actions"
@@ -42,4 +50,8 @@ updates:
       prefix: "chore"
       include: "scope"
     labels:
-      - "Type: Maintenance"
+      - "Type: Maintenance"
+    groups:
+      github-actions:
+        patterns:
+          - "*"

.github/workflows/lint-test.yml

@@ -24,7 +24,7 @@ jobs:
         run: sudo apt install libpcap-dev
 
       - name: Run golangci-lint
-        uses: golangci/golangci-lint-action@v6.2.0
+        uses: golangci/golangci-lint-action@v7.0.0
         with:
           version: latest
           args: --timeout 5m

.github/workflows/release-binary.yml

@@ -46,7 +46,29 @@ jobs:
         uses: goreleaser/goreleaser-action@v6
         with:
           version: latest
-          args: release -f .goreleaser/linux.yml --clean
+          args: release -f .goreleaser/linux-amd64.yml --clean
+          workdir: /
+
+  build-linux-arm64:
+    runs-on: ubuntu-24.04-arm
+    steps:
+      - name: Code checkout
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Set up Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: 1.21.x
+      - name: Install Dependences
+        run: sudo apt install libpcap-dev
+
+      - name: Run GoReleaser
+        uses: goreleaser/goreleaser-action@v6
+        with:
+          version: latest
+          args: release -f .goreleaser/linux-arm64.yml --clean
+          workdir: /
         env: 
           GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
           SLACK_WEBHOOK: "${{ secrets.RELEASE_SLACK_WEBHOOK }}"

.goreleaser/linux-amd64.yml

@@ -0,0 +1,36 @@
+env:
+  - GO111MODULE=on
+before:
+  hooks:
+    - go mod tidy
+project_name: naabu
+builds:
+  - id: naabu-linux-amd64
+    ldflags:
+      - -s -w
+    binary: naabu
+    env:
+      - CGO_ENABLED=1
+    main: ./cmd/naabu/main.go
+    goos:
+      - linux
+    goarch:
+      - amd64
+      
+archives:
+- format: zip
+  name_template: '{{ .ProjectName }}_{{ .Version }}_{{ if eq .Os "darwin" }}macOS{{ else }}{{ .Os }}{{ end }}_{{ .Arch }}'
+
+checksum:
+  name_template: "{{ .ProjectName }}-linux-amd64-checksums.txt"
+
+announce:
+  slack:
+    enabled: true
+    channel: '#release'
+    username: GoReleaser
+    message_template: 'New Release: {{ .ProjectName }} {{.Tag}} is published! Check it out at {{ .ReleaseURL }}'
+
+  discord:
+    enabled: true
+    message_template: '**New Release: {{ .ProjectName }} {{.Tag}}** is published! Check it out at {{ .ReleaseURL }}' 

.goreleaser/linux-arm64.yml

@@ -0,0 +1,36 @@
+env:
+  - GO111MODULE=on
+before:
+  hooks:
+    - go mod tidy
+project_name: naabu
+builds:
+  - id: naabu-linux-arm64
+    ldflags:
+      - -s -w
+    binary: naabu
+    env:
+      - CGO_ENABLED=1
+    main: ./cmd/naabu/main.go
+    goos:
+      - linux
+    goarch:
+      - arm64
+      
+archives:
+- format: zip
+  name_template: '{{ .ProjectName }}_{{ .Version }}_{{ if eq .Os "darwin" }}macOS{{ else }}{{ .Os }}{{ end }}_{{ .Arch }}'
+
+checksum:
+  name_template: "{{ .ProjectName }}-linux-arm64-checksums.txt"
+
+announce:
+  slack:
+    enabled: false
+    channel: '#release'
+    username: GoReleaser
+    message_template: 'New Release: {{ .ProjectName }} {{.Tag}} is published! Check it out at {{ .ReleaseURL }}'
+
+  discord:
+    enabled: false
+    message_template: '**New Release: {{ .ProjectName }} {{.Tag}}** is published! Check it out at {{ .ReleaseURL }}' 

Dockerfile

@@ -1,13 +1,13 @@
 # Build
-FROM golang:1.23.5-alpine AS build-env
+FROM golang:1.24.5-alpine AS build-env
 RUN apk add --no-cache build-base libpcap-dev
 WORKDIR /app
 COPY . /app
 RUN go mod download
 RUN go build ./cmd/naabu
 
 # Release
-FROM alpine:3.21.2
+FROM alpine:3.22.0
 RUN apk upgrade --no-cache \
     && apk add --no-cache nmap libpcap-dev bind-tools ca-certificates nmap-scripts
 COPY --from=build-env /app/naabu /usr/local/bin/

README.md

@@ -134,6 +134,15 @@ DEBUG:
    -stats                    display stats of the running scan (deprecated)
    -si, -stats-interval int  number of seconds to wait between showing a statistics update (deprecated) (default 5)
    -mp, -metrics-port int    port to expose naabu metrics on (default 63636)
+
+CLOUD:
+   -auth                           configure projectdiscovery cloud (pdcp) api key (default true)
+   -ac, -auth-config string        configure projectdiscovery cloud (pdcp) api key credential file
+   -pd, -dashboard                 upload / view output in projectdiscovery cloud (pdcp) UI dashboard
+   -tid, -team-id string           upload asset results to given team id (optional)
+   -aid, -asset-id string          upload new assets to existing asset id (optional)
+   -aname, -asset-name string      assets group name to set (optional)
+   -pdu, -dashboard-upload string  upload naabu output file (jsonl) in projectdiscovery cloud (pdcp) UI dashboard
 ```
 
 # Installation Instructions

cmd/functional-test/main.go

@@ -41,7 +41,11 @@ func runFunctionalTests() error {
 	if err != nil {
 		return errors.Wrap(err, "could not open test cases")
 	}
-	defer file.Close()
+	defer func() {
+		if err := file.Close(); err != nil {
+			log.Printf("could not close test cases file: %s\n", err)
+		}
+	}()
 
 	scanner := bufio.NewScanner(file)
 	for scanner.Scan() {

cmd/integration-test/library.go

@@ -3,6 +3,7 @@ package main
 import (
 	"context"
 	"errors"
+	"log"
 	"os"
 	"os/user"
 	"time"
@@ -32,7 +33,11 @@ func (h *naabuPassiveSingleLibrary) Execute() error {
 	if err != nil {
 		return err
 	}
-	defer os.RemoveAll(testFile)
+	defer func() {
+		if err := os.RemoveAll(testFile); err != nil {
+			log.Printf("could not remove test file: %s\n", err)
+		}
+	}()
 
 	options := runner.Options{
 		HostsFile: testFile,
@@ -45,7 +50,11 @@ func (h *naabuPassiveSingleLibrary) Execute() error {
 	if err != nil {
 		return err
 	}
-	defer naabuRunner.Close()
+	defer func() {
+		if err := naabuRunner.Close(); err != nil {
+			log.Printf("could not close naabu runner: %s\n", err)
+		}
+	}()
 
 	return naabuRunner.RunEnumeration(context.TODO())
 }
@@ -65,7 +74,11 @@ func (h *naabuSingleLibrary) Execute() error {
 	if err != nil {
 		return err
 	}
-	defer os.RemoveAll(testFile)
+	defer func() {
+		if err := os.RemoveAll(testFile); err != nil {
+			log.Printf("could not remove test file: %s\n", err)
+		}
+	}()
 
 	var got bool
 
@@ -83,7 +96,11 @@ func (h *naabuSingleLibrary) Execute() error {
 	if err != nil {
 		return err
 	}
-	defer naabuRunner.Close()
+	defer func() {
+		if err := naabuRunner.Close(); err != nil {
+			log.Printf("could not close naabu runner: %s\n", err)
+		}
+	}()
 
 	if err = naabuRunner.RunEnumeration(context.TODO()); err != nil {
 		return err
@@ -110,7 +127,11 @@ func (h *naabuMultipleExecLibrary) Execute() error {
 	if err != nil {
 		return err
 	}
-	defer os.RemoveAll(testFile)
+	defer func() {
+		if err := os.RemoveAll(testFile); err != nil {
+			log.Printf("could not remove test file: %s\n", err)
+		}
+	}()
 
 	var got bool
 
@@ -136,7 +157,9 @@ func (h *naabuMultipleExecLibrary) Execute() error {
 		if !got {
 			return errors.New("no results found")
 		}
-		naabuRunner.Close()
+		if err := naabuRunner.Close(); err != nil {
+			log.Printf("could not close naabu runner: %s\n", err)
+		}
 	}
 	return nil
 }
@@ -165,7 +188,11 @@ func (h *naabuWithSocks5) Execute() error {
 	if err != nil {
 		return err
 	}
-	defer os.RemoveAll(testFile)
+	defer func() {
+		if err := os.RemoveAll(testFile); err != nil {
+			log.Printf("could not remove test file: %s\n", err)
+		}
+	}()
 
 	var got bool
 
@@ -186,7 +213,11 @@ func (h *naabuWithSocks5) Execute() error {
 	if err != nil {
 		return err
 	}
-	defer naabuRunner.Close()
+	defer func() {
+		if err := naabuRunner.Close(); err != nil {
+			log.Printf("could not close naabu runner: %s\n", err)
+		}
+	}()
 
 	if err = naabuRunner.RunEnumeration(context.TODO()); err != nil {
 		return err