Skip to content

Commit 1605b09

Browse files
#6150: Remove names from tests to make tests easier to understand
1 parent 40416bf commit 1605b09

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

update/types_test.go

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,70 +1,62 @@
11
package updateutils
22

33
import (
4+
"fmt"
45
"testing"
56

67
"github.com/stretchr/testify/assert"
78
)
89

910
func TestIsOutdated(t *testing.T) {
1011
tests := []struct {
11-
name string
1212
current string
1313
latest string
1414
expected bool
1515
}{
1616
{
17-
name: "Current version is older than latest",
1817
current: "1.0.0",
1918
latest: "1.1.0",
2019
expected: true,
2120
},
2221
{
23-
name: "Current version is same as latest",
2422
current: "1.0.0",
2523
latest: "1.0.0",
2624
expected: false,
2725
},
2826
{
29-
name: "Current version is newer than latest",
3027
current: "1.1.0",
3128
latest: "1.0.0",
3229
expected: false,
3330
},
3431
{
35-
name: "Current version is dev version",
3632
current: "1.0.0-dev",
3733
latest: "1.0.0",
3834
expected: true,
3935
},
4036
{
41-
name: "Invalid version format - fallback to string comparison",
4237
current: "invalid",
4338
latest: "1.0.0",
4439
expected: true,
4540
},
4641
{
47-
name: "Both versions invalid - fallback to string comparison",
4842
current: "invalid1",
4943
latest: "invalid2",
5044
expected: true,
5145
},
5246
{
53-
name: "Pre-release version comparison",
5447
current: "1.0.0-alpha",
5548
latest: "1.0.0",
5649
expected: true,
5750
},
5851
{
59-
name: "Pre-release version comparison with same base version",
6052
current: "1.0.0-alpha",
6153
latest: "1.0.0-beta",
6254
expected: true,
6355
},
6456
}
6557

6658
for _, tt := range tests {
67-
t.Run(tt.name, func(t *testing.T) {
59+
t.Run(fmt.Sprintf("current: %v, latest: %v", tt.current, tt.latest), func(t *testing.T) {
6860
assert.Equal(t, tt.expected, IsOutdated(tt.current, tt.latest), "version comparison failed")
6961
})
7062
}

0 commit comments

Comments
 (0)