Regexp Utils (#652)

* regexp util

* lint

* adding .string()

* fix

* hiding warnings

* typo + tests

* bump go

---------

Co-authored-by: Doğan Can Bakır <dogancanbakir@protonmail.com>

Author: Mzack9999

.github/workflows/build-test.yml

@@ -15,7 +15,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v4
         with:
-          go-version: 1.21.x
+          go-version: 1.24.x
 
       - name: Check out code
         uses: actions/checkout@v3

.github/workflows/changelog-update.yml

@@ -13,7 +13,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v4
         with:
-          go-version: 1.21.x
+          go-version: 1.24.x
 
       - name: Checkout code
         uses: actions/checkout@v3

.github/workflows/lint-test.yml

@@ -15,7 +15,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v4
         with:
-          go-version: 1.21.x
+          go-version: 1.24.x
       - name: Run golangci-lint
         uses: golangci/golangci-lint-action@v3.7.0
         with:

auth/pdcp/auth.go

@@ -96,6 +96,8 @@ func readPasswordFromUnix() ([]byte, error) {
 	if err != nil {
 		return nil, err
 	}
-	defer tty.Close()
+	defer func() {
+		_ = tty.Close()
+	}()
 	return term.ReadPassword(int(tty.Fd()))
 }

auth/pdcp/creds.go

@@ -120,7 +120,9 @@ func (p *PDCPCredHandler) ValidateAPIKey(key string, host string, toolName strin
 		_ = resp.Body.Close()
 		return nil, fmt.Errorf("invalid status code: %d", resp.StatusCode)
 	}
-	defer resp.Body.Close()
+	defer func() {
+		_ = resp.Body.Close()
+	}()
 	bin, err := io.ReadAll(resp.Body)
 	if err != nil {
 		return nil, err

auth/pdcp/creds_test.go

@@ -21,7 +21,9 @@ func TestLoadCreds(t *testing.T) {
 	f, err := os.CreateTemp("", "creds-test-*")
 	require.Nil(t, err)
 	_, _ = f.WriteString(strings.TrimSpace(exampleCred))
-	defer os.Remove(f.Name())
+	defer func() {
+		_ = os.Remove(f.Name())
+	}()
 	PDCPCredFile = f.Name()
 	PDCPDir = filepath.Dir(f.Name())
 	h := &PDCPCredHandler{}

buffer/disk.go

@@ -47,6 +47,6 @@ func (db *DiskBuffer) Reader() (io.ReadSeekCloser, error) {
 
 func (db *DiskBuffer) Close() {
 	name := db.f.Name()
-	db.f.Close()
-	os.RemoveAll(name)
+	_ = db.f.Close()
+	_ = os.RemoveAll(name)
 }

env/env_test.go

@@ -9,8 +9,10 @@ import (
 func TestExpandWithEnv(t *testing.T) {
 	testEnvVar := "TEST_VAR"
 	testEnvValue := "TestValue"
-	os.Setenv(testEnvVar, testEnvValue)
-	defer os.Unsetenv(testEnvVar)
+	_ = os.Setenv(testEnvVar, testEnvValue)
+	defer func() {
+		_ = os.Unsetenv(testEnvVar)
+	}()
 
 	tests := []struct {
 		input    string
@@ -46,35 +48,35 @@ func TestExpandWithEnvNilInput(t *testing.T) {
 
 func TestGetEnvOrDefault(t *testing.T) {
 	// Test for string
-	os.Setenv("TEST_STRING", "test")
+	_ = os.Setenv("TEST_STRING", "test")
 	resultString := GetEnvOrDefault("TEST_STRING", "default")
 	if resultString != "test" {
 		t.Errorf("Expected 'test', got %s", resultString)
 	}
 
 	// Test for int
-	os.Setenv("TEST_INT", "123")
+	_ = os.Setenv("TEST_INT", "123")
 	resultInt := GetEnvOrDefault("TEST_INT", 0)
 	if resultInt != 123 {
 		t.Errorf("Expected 123, got %d", resultInt)
 	}
 
 	// Test for bool
-	os.Setenv("TEST_BOOL", "true")
+	_ = os.Setenv("TEST_BOOL", "true")
 	resultBool := GetEnvOrDefault("TEST_BOOL", false)
 	if resultBool != true {
 		t.Errorf("Expected true, got %t", resultBool)
 	}
 
 	// Test for float64
-	os.Setenv("TEST_FLOAT", "1.23")
+	_ = os.Setenv("TEST_FLOAT", "1.23")
 	resultFloat := GetEnvOrDefault("TEST_FLOAT", 0.0)
 	if resultFloat != 1.23 {
 		t.Errorf("Expected 1.23, got %f", resultFloat)
 	}
 
 	// Test for time.Duration
-	os.Setenv("TEST_DURATION", "1h")
+	_ = os.Setenv("TEST_DURATION", "1h")
 	resultDuration := GetEnvOrDefault("TEST_DURATION", time.Duration(0))
 	if resultDuration != time.Hour {
 		t.Errorf("Expected 1h, got %s", resultDuration)

errkit/errors.go

@@ -375,7 +375,7 @@ func parseError(to *ErrorX, err error) {
 		}
 	case CauseError:
 		to.append(v.Cause())
-		remaining := strings.Replace(err.Error(), v.Cause().Error(), "", -1)
+		remaining := strings.ReplaceAll(err.Error(), v.Cause().Error(), "")
 		parseError(to, errors.New(remaining))
 	default:
 		errString := err.Error()

exec/executil.go

@@ -157,9 +157,11 @@ func RunSafe(cmd ...string) (string, error) {
 		return "", errkit.WithMessage(err, "failed to create stdout pipe")
 	}
 
-	defer in.Close()
-	defer errorOut.Close()
-	defer out.Close()
+	defer func() {
+		_ = in.Close()
+		_ = errorOut.Close()
+		_ = out.Close()
+	}()
 
 	if err := cmdExec.Start(); err != nil {
 		return "", errkit.Wrap(err, "failed to start command")
@@ -199,9 +201,11 @@ func RunSh(cmd ...string) (string, error) {
 		return "", errkit.WithMessage(err, "failed to create stdout pipe")
 	}
 
-	defer in.Close()
-	defer errorOut.Close()
-	defer out.Close()
+	defer func() {
+		_ = in.Close()
+		_ = errorOut.Close()
+		_ = out.Close()
+	}()
 
 	if err := cmdExec.Start(); err != nil {
 		errorData, _ := io.ReadAll(errorOut)
@@ -257,9 +261,11 @@ func RunPS(cmd string) (string, error) {
 		return "", errkit.WithMessage(err, "failed to create stdout pipe")
 	}
 
-	defer in.Close()
-	defer errorOut.Close()
-	defer out.Close()
+	defer func() {
+		_ = in.Close()
+		_ = errorOut.Close()
+		_ = out.Close()
+	}()
 
 	if err := cmdExec.Start(); err != nil {
 		return "", errkit.WithMessage(err, "start powershell.exe process error")