fix(bundle): Handle selector with no variants as a syntax error

Author: eemeli

fluent-bundle/src/resource.ts

@@ -273,7 +273,7 @@ function parseMessage(source: string, cursor: number, id: string): Message {
         type: "select",
         selector: expression,
         ...variants,
-      } as SelectExpression; // TODO: FIXME
+      } satisfies SelectExpression;
     }
 
     throw new SyntaxError("Unclosed placeable");
@@ -363,30 +363,25 @@ function parseMessage(source: string, cursor: number, id: string): Message {
   function parseVariants(): {
     variants: Array<Variant>;
     star: number;
-  } | null {
+  } {
     const variants: Array<Variant> = [];
-    let count = 0;
     let star;
 
     RE_VARIANT_START.lastIndex = cursor;
     while (RE_VARIANT_START.test(source)) {
       if (consumeChar("*")) {
-        star = count;
+        star = variants.length;
       }
 
       const key = parseVariantKey();
       const value = parsePattern();
       if (value === null) {
         throw new SyntaxError("Expected variant value");
       }
-      variants[count++] = { key, value };
+      variants.push({ key, value });
       RE_VARIANT_START.lastIndex = cursor;
     }
 
-    if (count === 0) {
-      return null;
-    }
-
     if (star === undefined) {
       throw new SyntaxError("Expected default variant");
     }

fluent-bundle/test/fixtures_reference/cr.json

@@ -21,19 +21,6 @@
             "attributes": {
                 "title": "Title"
             }
-        },
-        {
-            "id": "err05",
-            "value": [
-                {
-                    "type": "select",
-                    "selector": {
-                        "type": "var",
-                        "name": "sel"
-                    }
-                }
-            ],
-            "attributes": {}
         }
     ]
 }

fluent-bundle/test/fixtures_reference/crlf.json

@@ -15,19 +15,6 @@
             "attributes": {
                 "title": "Title"
             }
-        },
-        {
-            "id": "err04",
-            "value": [
-                {
-                    "type": "select",
-                    "selector": {
-                        "type": "var",
-                        "name": "sel"
-                    }
-                }
-            ],
-            "attributes": {}
         }
     ]
 }

fluent-bundle/test/fixtures_structure/crlf.json

@@ -15,19 +15,6 @@
             "attributes": {
                 "title": "Title"
             }
-        },
-        {
-            "id": "err04",
-            "value": [
-                {
-                    "type": "select",
-                    "selector": {
-                        "type": "var",
-                        "name": "sel"
-                    }
-                }
-            ],
-            "attributes": {}
         }
     ]
 }

fluent-bundle/test/fixtures_structure/select_expression_without_variants.json

@@ -1,30 +1,3 @@
 {
-    "body": [
-        {
-            "id": "err01",
-            "value": [
-                {
-                    "type": "select",
-                    "selector": {
-                        "type": "var",
-                        "name": "foo"
-                    }
-                }
-            ],
-            "attributes": {}
-        },
-        {
-            "id": "err02",
-            "value": [
-                {
-                    "type": "select",
-                    "selector": {
-                        "type": "var",
-                        "name": "foo"
-                    }
-                }
-            ],
-            "attributes": {}
-        }
-    ]
+    "body": []
 }