Skip to content

Commit c5c5eda

Browse files
henrydavidgeHenry Davidge
andauthored
Rename quinary expression in Glow (#635)
Signed-off-by: Henry Davidge <henry@davidge.me> Co-authored-by: Henry Davidge <henry@davidge.me>
1 parent 5bc4514 commit c5c5eda

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

core/src/main/scala/io/projectglow/sql/expressions/LogisticRegressionExpr.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import org.apache.spark.sql.SQLUtils
2222
import org.apache.spark.sql.catalyst.InternalRow
2323
import org.apache.spark.sql.catalyst.analysis.TypeCheckResult
2424
import org.apache.spark.sql.catalyst.expressions.codegen.{CodegenContext, ExprCode}
25-
import org.apache.spark.sql.catalyst.expressions.{Expression, ImplicitCastInputTypes, QuinaryExpression}
25+
import org.apache.spark.sql.catalyst.expressions.{Expression, ImplicitCastInputTypes, QuinaryOptionalExpression}
2626
import org.apache.spark.sql.catalyst.util.ArrayData
2727
import org.apache.spark.sql.types.{ArrayType, DataType, DoubleType, StringType}
2828
import org.apache.spark.unsafe.types.UTF8String
@@ -139,7 +139,7 @@ case class LogisticRegressionExpr(
139139
covariates: Expression,
140140
test: Expression,
141141
offsetOption: Option[Expression])
142-
extends QuinaryExpression
142+
extends QuinaryOptionalExpression
143143
with ImplicitCastInputTypes {
144144

145145
def this(

core/src/main/scala/org/apache/spark/sql/catalyst/expressions/QuinaryExpression.scala renamed to core/src/main/scala/org/apache/spark/sql/catalyst/expressions/QuinaryOptionalExpression.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import org.apache.spark.sql.catalyst.expressions.codegen._
2424
* An expression with four inputs + 5th optional input.
2525
* The output is by default evaluated to null if any input is evaluated to null.
2626
*/
27-
abstract class QuinaryExpression extends Expression {
27+
abstract class QuinaryOptionalExpression extends Expression {
2828

2929
override def foldable: Boolean = children.forall(_.foldable)
3030

core/src/test/scala/org/apache/spark/sql/catalyst/expressions/QuinaryExpressionSuite.scala renamed to core/src/test/scala/org/apache/spark/sql/catalyst/expressions/QuinaryOptionalExpressionSuite.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ case class testQuinaryExpr(
2727
child3: Expression,
2828
child4: Expression,
2929
child5: Option[Expression])
30-
extends QuinaryExpression {
30+
extends QuinaryOptionalExpression {
3131

3232
override def dataType: DataType = IntegerType
3333

@@ -55,7 +55,7 @@ case class testQuinaryExpr(
5555
child5 = Option(newChildren(5)))
5656
}
5757

58-
class QuinaryExpressionSuite extends GlowBaseTest {
58+
class QuinaryOptionalExpressionSuite extends GlowBaseTest {
5959
test("nullSafeCodeGen for un-nullable expression with Some argument") {
6060
val ctx = new CodegenContext
6161
val testExpr = testQuinaryExpr(

0 commit comments

Comments
 (0)