Skip to content

Commit ad26d66

Browse files
authored
cel-standalone: do not include Jackson (#482)
Relocating Jackson can cause stack-overflow exception, as seen in [this check run](https://github.com/projectnessie/nessie/actions/runs/6934341817/job/18862247196?pr=7738).
1 parent 682ba36 commit ad26d66

File tree

2 files changed

+3
-13
lines changed

2 files changed

+3
-13
lines changed

README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,11 +204,13 @@ dependencies {
204204
## Dependency-free artifact
205205

206206
The `org.projectnessie.cel:cel-standalone` contains everything from CEL-Java and has no dependencies.
207-
It comes with relocated dependencies.
207+
It comes with relocated protobuf dependencies.
208208

209209
Using `cel-standalone` is especially useful when your project requires different versions of
210210
`protobuf-java`.
211211

212+
If you need CEL-Java's Jackson functionality, include the Jackson dependencies in your project.
213+
212214
Use _either_ `cel-tools` _or_ `cel-standalone` - never both!
213215

214216
## Motivation to have a CEL-Java port

standalone/build.gradle.kts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -31,19 +31,12 @@ dependencies {
3131

3232
compileOnly(libs.protobuf.java)
3333
compileOnly(libs.agrona)
34-
35-
compileOnly(platform(libs.jackson.bom))
36-
compileOnly("com.fasterxml.jackson.core:jackson-databind")
37-
compileOnly("com.fasterxml.jackson.core:jackson-core")
38-
compileOnly("com.fasterxml.jackson.dataformat:jackson-dataformat-protobuf")
39-
compileOnly("com.fasterxml.jackson.dataformat:jackson-dataformat-yaml")
4034
}
4135

4236
val shadowJar = tasks.named<ShadowJar>("shadowJar")
4337

4438
shadowJar.configure {
4539
relocate("com.google.protobuf", "org.projectnessie.cel.relocated.protobuf")
46-
relocate("com.fasterxml.jackson", "org.projectnessie.cel.relocated.jackson")
4740
relocate("org.agrona", "org.projectnessie.cel.relocated.agrona")
4841
manifest {
4942
attributes["Specification-Title"] = "Common-Expression-Language - dependency-free CEL"
@@ -58,11 +51,6 @@ shadowJar.configure {
5851
include(project(":cel-generated-antlr"))
5952

6053
include(dependency(libs.protobuf.java.get()))
61-
include(dependency("com.fasterxml.jackson.core:jackson-databind"))
62-
include(dependency("com.fasterxml.jackson.core:jackson-core"))
63-
include(dependency("com.fasterxml.jackson.core:jackson-annotations"))
64-
include(dependency("com.fasterxml.jackson.dataformat:jackson-dataformat-protobuf"))
65-
include(dependency("com.fasterxml.jackson.dataformat:jackson-dataformat-yaml"))
6654
include(dependency(libs.agrona.get()))
6755
}
6856
}

0 commit comments

Comments
 (0)