Omit unnecessary Requeue: true when returning an error from the reconcile loop

Author: simu

controllers/configmap_controller.go

@@ -74,11 +74,8 @@ func (r *ConfigMapReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
 	serviceCA, err := certs.GetServiceCA(ctx, r.Client, l, r.CANamespace)
 	if err != nil {
 		l.Info("Service CA not ready yet, requeuing request")
-		return ctrl.Result{
-			Requeue: true,
-		}, err
+		return ctrl.Result{}, err
 	}
-
 	cmLabels := cm.Labels
 	if cmLabels == nil {
 		// nothing to do, exit

controllers/service_controller.go

@@ -91,9 +91,7 @@ func (r *ServiceReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
 	_, err = certs.GetServiceCA(ctx, r.Client, l, r.CANamespace)
 	if err != nil {
 		l.Info("Service CA not ready yet, requeuing request")
-		return ctrl.Result{
-			Requeue: true,
-		}, err
+		return ctrl.Result{}, err
 	}
 
 	l.V(1).Info("Reconciling certificate for service")

controllers/service_controller_test.go

@@ -69,7 +69,7 @@ func TestSvcController_Reconcile(t *testing.T) {
 				&labeledService,
 			},
 			err: fmt.Errorf("CA certificate not yet ready"),
-			res: ctrl.Result{Requeue: true},
+			res: ctrl.Result{},
 		},
 		"LabeledService_CAReady": {
 			objects: append(