Skip to content

Commit 9a96b71

Browse files
authored
chore(deps): upgrade css-code-coverage to 0.8.0 (#66)
1 parent ceb5e2d commit 9a96b71

File tree

4 files changed

+9
-15
lines changed

4 files changed

+9
-15
lines changed

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@
1515
"check": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json",
1616
"lint": "oxlint --config oxlintrc.json",
1717
"stylelint": "stylelint \"src/**/*.{css,svelte}\" --ignore-path .gitignore",
18-
"css-coverage": "css-coverage --coverage-dir=./css-coverage --min-line-coverage=.8 --min-file-line-coverage=.62 --show-uncovered=all"
18+
"css-coverage": "css-coverage --coverage-dir=./css-coverage --min-coverage=.8 --min-file-coverage=.66 --show-uncovered=all"
1919
},
2020
"dependencies": {
2121
"@bramus/specificity": "^2.4.2",
2222
"@melt-ui/pp": "^0.3.2",
2323
"@melt-ui/svelte": "^0.86.6",
2424
"@oddbird/popover-polyfill": "^0.6.1",
2525
"@projectwallace/css-analyzer": "^7.6.0",
26-
"@projectwallace/css-code-coverage": "^0.7.0",
26+
"@projectwallace/css-code-coverage": "^0.8.0",
2727
"@projectwallace/css-code-quality": "^3.0.2",
2828
"@projectwallace/css-design-tokens": "^0.10.0",
2929
"@projectwallace/css-layer-tree": "^2.0.0",

src/lib/components/Pre.svelte

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,6 @@
328328
overflow: auto hidden;
329329
max-height: 100%;
330330
height: 100%;
331-
scroll-margin: var(--space-4);
332331
color: var(--fg-200);
333332
334333
/* Regular outline not visible because of scroll containers */

src/lib/components/coverage/Coverage.svelte

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import Panel from '$components/Panel.svelte'
77
import Meter from '$components/Meter.svelte'
88
import Pre from '$components/Pre.svelte'
9-
import { calculate_coverage, type Coverage, type CoverageResult } from '@projectwallace/css-code-coverage'
9+
import { calculate_coverage, type Coverage } from '@projectwallace/css-code-coverage'
1010
import Empty from '$components/Empty.svelte'
1111
import Table from '$components/Table.svelte'
1212
import { string_sort } from '$lib/string-sort'
@@ -21,13 +21,8 @@
2121
elements: { root, item }
2222
} = create_keyboard_list()
2323
let selected_index = $state(0)
24-
let calculated: CoverageResult | undefined = $state(undefined)
25-
26-
// TODO: this should be a $derived() but apparently the library isn't side-effect free
27-
// https://github.com/projectwallace/css-code-coverage/issues/28
28-
$effect(() => {
29-
calculated = calculate_coverage(browser_coverage)
30-
})
24+
// $state.snapshot() necessary to avoid "unsafe state mutation" errors
25+
let calculated = $derived(calculate_coverage($state.snapshot(browser_coverage)))
3126
3227
let max_lines = $derived.by(() => {
3328
if (!calculated) return 0

0 commit comments

Comments
 (0)